[prev in list] [next in list] [prev in thread] [next in thread]
List: vdsm-devel
Subject: Re: [ovirt-devel] Building the oVirt Engine master branch fails due to isort, python issues
From: Sandro Bonazzola <sbonazzo () redhat ! com>
Date: 2018-02-27 9:38:49
Message-ID: CAPQRNT=_4=K-vc2M3752KGm7D=A-DaLoeL_K6BeKPZAr6BzkuA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Fixed in https://gerrit.ovirt.org/88221
2018-02-26 14:48 GMT+01:00 Yedidyah Bar David <didi@redhat.com>:
> On Mon, Feb 26, 2018 at 3:37 PM, Martin Perina <mperina@redhat.com> wrote:
> > Strange, I've just tried to build latest master using
> > python2-isort-4.2.5-8.el7 on latest RHEL 7.4 and it finished successfully
> > without any errors ...
> >
> > On Mon, Feb 26, 2018 at 2:31 PM, Yedidyah Bar David <didi@redhat.com>
> wrote:
> >>
> >> On Mon, Feb 26, 2018 at 3:19 PM, Steven Rosenberg <srosenbe@redhat.com>
> >> wrote:
> >> > Dear Yedidyah,
> >> >
> >> > Thank you for your response. I have attached the two dump files. The
> >> > first
> >> > is the original error for isort, dump.txt. The second dump_isort.txt
> is
> >> > after installing python2_isort.
> >>
> >> This is the error:
> >>
> >> pep8 <lots of files>
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:474:25:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:481:25:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:488:25:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:635:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:637:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:639:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:641:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:645:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:652:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:654:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:658:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:663:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:664:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:872:13:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/
> configuration.py:255:13:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/
> database.py:313:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/
> database.py:314:21:
> >> E126 continuation line over-indented for hanging indent
> >>
> >> packaging/setup/plugins/ovirt-engine-common/base/core/
> duplicated_constants_check.py:109:17:
> >> E124 closing bracket does not match visual indentation
> >> + ret=1
> >>
> >> Perhaps a newer version of pep8 finds more bugs in our code.
> >>
> >> Pushed this to get a more explanatory error:
> >>
> >> https://gerrit.ovirt.org/88186
>
> Since it seems to pass on upstream CI, can you please rebase
> on above patch and see if you get a proper error message?
> And also please mark 'verified' :-) Thanks!
>
> >>
> >> Best regards,
> >>
> >> >
> >> > With Best Regards.
> >> >
> >> > Steven Rosenberg.
> >> >
> >> > On Mon, Feb 26, 2018 at 3:10 PM, Yedidyah Bar David <didi@redhat.com>
> >> > wrote:
> >> >>
> >> >> Hi,
> >> >>
> >> >> On Mon, Feb 26, 2018 at 2:39 PM, Steven Rosenberg <
> srosenbe@redhat.com>
> >> >> wrote:
> >> >> > Dear Martin,
> >> >> >
> >> >> > I should add I am running RHEL 7.4 (Maipo).
> >> >> >
> >> >> > With Best Regards.
> >> >> >
> >> >> > Steven Rosenberg.
> >> >> >
> >> >> > On Mon, Feb 26, 2018 at 2:24 PM, Martin Perina <mperina@redhat.com
> >
> >> >> > wrote:
> >> >> >>
> >> >> >> Didi/Sandro, any ideas about it? AFAIK on CentOS/RHEL 7 everything
> >> >> >> works
> >> >> >> as expected ...
> >> >> >>
> >> >> >>
> >> >> >> On Mon, Feb 26, 2018 at 11:58 AM, Steven Rosenberg
> >> >> >> <srosenbe@redhat.com>
> >> >> >> wrote:
> >> >> >>>
> >> >> >>> Dear Martin Perina,
> >> >> >>>
> >> >> >>> We found some issues with the oVirt Engine master branch when
> >> >> >>> updating
> >> >> >>> the version via git pull.
> >> >> >>>
> >> >> >>> We then performed the make command:
> >> >> >>>
> >> >> >>> make clean install-dev PREFIX=~/ovirt_engine_master
> >> >> >>> DEV_BUILD_SCL_POSTGRESQL=1
> >> >> >>>
> >> >> >>> It seems a new dependency was added for isort, so the make fails
> >> >> >>> with
> >> >> >>> the
> >> >> >>> following error:
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> ------------------------------------------------------------
> --------------------------------------------------------
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/
> database.py:313:21:
> >> >> >>> E126 continuation line over-indented for hanging indent
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/
> database.py:314:21:
> >> >> >>> E126 continuation line over-indented for hanging indent
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> packaging/setup/plugins/ovirt-engine-common/base/core/
> duplicated_constants_check.py:109:17:
> >> >> >>> E124 closing bracket does not match visual indentation
> >> >> >>> + ret=1
> >> >> >>> + which isort
> >> >> >>> + echo 'WARNING: tool '\''isort'\'' is missing'
> >> >> >>> WARNING: tool 'isort' is missing
> >> >>
> >> >> This is just a warning
> >> >>
> >> >> >>> + exit 1
> >> >>
> >> >> Most likely the error causing it to exit 1 happened earlier, please
> >> >> check/share
> >> >> more of the output.
> >> >>
> >> >> >>> make[1]: *** [validations] Error 1
> >> >> >>> make[1]: Leaving directory
> >> >> >>> `/home/srosenbe/Documents/git/ovirt-engine'
> >> >> >>> make: *** [all-dev] Error 2
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> ------------------------------------------------------------
> --------------------------------------------------------
> >> >> >>>
> >> >> >>> To attempt to address this issue, we guessed and installed
> >> >> >>> python2-isort
> >> >> >>> through yum, though the readme states it is optional.
> >> >> >>>
> >> >> >>> Though the process continued, it then failed in the python
> module:
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> /home/srosenbe/Documents/git/ovirt-engine/packaging/
> pythonlib/ovirt_engine/service.py
> >> >> >>>
> >> >> >>> That error is here:
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> ------------------------------------------------------------
> ---------------------------------------------------------------
> >> >> >>>
> >> >> >>>
> >> >> >>> ---
> >> >> >>>
> >> >> >>>
> >> >> >>> /home/srosenbe/Documents/git/ovirt-engine/packaging/
> pythonlib/ovirt_engine/service.py:before
> >> >> >>> 2018-02-12 12:17:26
> >> >> >>> +++
> >> >> >>>
> >> >> >>>
> >> >> >>> /home/srosenbe/Documents/git/ovirt-engine/packaging/
> pythonlib/ovirt_engine/service.py:after
> >> >> >>> 2018-02-26 12:07:11.233915
> >> >> >>> @@ -31,6 +31,7 @@
> >> >> >>> import time
> >> >> >>>
> >> >> >>> import daemon
> >> >> >>> +
> >> >> >>>
> >> >> >>> from dateutil import tz
> >> >> >>>
> >> >>
> >> >> This is an output of 'isort --diff', and not the actual error.
> >> >>
> >> >> (isort --check, which is what we run to test the code, does not fail
> if
> >> >> the diff it would have suggested consists of only difference in the
> >> >> number
> >> >> of empty lines. It would still be nice to patch service.py to have
> >> >> another
> >> >> empty line, but not needed).
> >> >>
> >> >> >>> + exit 1
> >> >>
> >> >> Same. Error was most likely earlier.
> >> >>
> >> >> Best regards,
> >> >>
> >> >> >>> make[1]: *** [validations] Error 1
> >> >> >>> make[1]: Leaving directory
> >> >> >>> `/home/srosenbe/Documents/git/ovirt-engine'
> >> >> >>> make: *** [all-dev] Error 2
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> ------------------------------------------------------------
> ---------------------------------------------------------------
> >> >> >>>
> >> >> >>> Please advise if you have a quick fix or when this issue will be
> >> >> >>> addressed.
> >> >> >>>
> >> >> >>> Thank you for your time and consideration.
> >> >> >>>
> >> >> >>> With Best Regards.
> >> >> >>>
> >> >> >>> Steven Rosenberg.
> >> >> >>>
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> --
> >> >> >> Martin Perina
> >> >> >> Associate Manager, Software Engineering
> >> >> >> Red Hat Czech s.r.o.
> >> >> >
> >> >> >
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Didi
> >> >
> >> >
> >>
> >>
> >>
> >> --
> >> Didi
> >
> >
> >
> >
> > --
> > Martin Perina
> > Associate Manager, Software Engineering
> > Red Hat Czech s.r.o.
>
>
>
> --
> Didi
>
--
SANDRO BONAZZOLA
ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D
Red Hat EMEA <https://www.redhat.com/>
<https://red.ht/sig>
TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
[Attachment #5 (text/html)]
<div dir="ltr">Fixed in <a \
href="https://gerrit.ovirt.org/88221">https://gerrit.ovirt.org/88221</a><br><div \
class="gmail_extra"><br><div class="gmail_quote">2018-02-26 14:48 GMT+01:00 Yedidyah \
Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" \
target="_blank">didi@redhat.com</a>></span>:<br><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">On \
Mon, Feb 26, 2018 at 3:37 PM, Martin Perina <<a \
href="mailto:mperina@redhat.com">mperina@redhat.com</a>> wrote:<br> > Strange, \
I've just tried to build latest master using<br> > python2-isort-4.2.5-8.el7 \
on latest RHEL 7.4 and it finished successfully<br> > without any errors ...<br>
><br>
> On Mon, Feb 26, 2018 at 2:31 PM, Yedidyah Bar David <<a \
href="mailto:didi@redhat.com">didi@redhat.com</a>> wrote:<br> >><br>
>> On Mon, Feb 26, 2018 at 3:19 PM, Steven Rosenberg <<a \
href="mailto:srosenbe@redhat.com">srosenbe@redhat.com</a>><br> >> wrote:<br>
>> > Dear Yedidyah,<br>
>> ><br>
>> > Thank you for your response. I have attached the two dump files. \
The<br> >> > first<br>
>> > is the original error for isort, dump.txt. The second dump_isort.txt \
is<br> >> > after installing python2_isort.<br>
>><br>
>> This is the error:<br>
>><br>
>> pep8 <lots of files><br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>474:25:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>481:25:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>488:25:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>635:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>637:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>639:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>641:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>645:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>652:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>654:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>658:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>663:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>664:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>872:13:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/db/<wbr>configuration.py:255:13:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:313:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:314:21:<br>
>> E126 continuation line over-indented for hanging indent<br>
>><br>
>> packaging/setup/plugins/ovirt-<wbr>engine-common/base/core/<wbr>duplicated_constants_check.py:<wbr>109:17:<br>
>> E124 closing bracket does not match visual indentation<br>
>> + ret=1<br>
>><br>
>> Perhaps a newer version of pep8 finds more bugs in our code.<br>
>><br>
>> Pushed this to get a more explanatory error:<br>
>><br>
>> <a href="https://gerrit.ovirt.org/88186" rel="noreferrer" \
target="_blank">https://gerrit.ovirt.org/88186</a><br> <br>
</div></div>Since it seems to pass on upstream CI, can you please rebase<br>
on above patch and see if you get a proper error message?<br>
And also please mark 'verified' :-) Thanks!<br>
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
>><br>
>> Best regards,<br>
>><br>
>> ><br>
>> > With Best Regards.<br>
>> ><br>
>> > Steven Rosenberg.<br>
>> ><br>
>> > On Mon, Feb 26, 2018 at 3:10 PM, Yedidyah Bar David <<a \
href="mailto:didi@redhat.com">didi@redhat.com</a>><br> >> > wrote:<br>
>> >><br>
>> >> Hi,<br>
>> >><br>
>> >> On Mon, Feb 26, 2018 at 2:39 PM, Steven Rosenberg <<a \
href="mailto:srosenbe@redhat.com">srosenbe@redhat.com</a>><br> >> >> \
wrote:<br> >> >> > Dear Martin,<br>
>> >> ><br>
>> >> > I should add I am running RHEL 7.4 (Maipo).<br>
>> >> ><br>
>> >> > With Best Regards.<br>
>> >> ><br>
>> >> > Steven Rosenberg.<br>
>> >> ><br>
>> >> > On Mon, Feb 26, 2018 at 2:24 PM, Martin Perina <<a \
href="mailto:mperina@redhat.com">mperina@redhat.com</a>><br> >> >> \
> wrote:<br> >> >> >><br>
>> >> >> Didi/Sandro, any ideas about it? AFAIK on CentOS/RHEL 7 \
everything<br> >> >> >> works<br>
>> >> >> as expected ...<br>
>> >> >><br>
>> >> >><br>
>> >> >> On Mon, Feb 26, 2018 at 11:58 AM, Steven Rosenberg<br>
>> >> >> <<a \
href="mailto:srosenbe@redhat.com">srosenbe@redhat.com</a>><br> >> >> \
>> wrote:<br> >> >> >>><br>
>> >> >>> Dear Martin Perina,<br>
>> >> >>><br>
>> >> >>> We found some issues with the oVirt Engine master \
branch when<br> >> >> >>> updating<br>
>> >> >>> the version via git pull.<br>
>> >> >>><br>
>> >> >>> We then performed the make command:<br>
>> >> >>><br>
>> >> >>> make clean install-dev \
PREFIX=~/ovirt_engine_master<br> >> >> >>> \
DEV_BUILD_SCL_POSTGRESQL=1<br> >> >> >>><br>
>> >> >>> It seems a new dependency was added for isort, so the \
make fails<br> >> >> >>> with<br>
>> >> >>> the<br>
>> >> >>> following error:<br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>--------------------------<br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:313:21:<br>
>> >> >>> E126 continuation line over-indented for hanging \
indent<br> >> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:314:21:<br>
>> >> >>> E126 continuation line over-indented for hanging \
indent<br> >> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
packaging/setup/plugins/ovirt-<wbr>engine-common/base/core/<wbr>duplicated_constants_check.py:<wbr>109:17:<br>
>> >> >>> E124 closing bracket does not match visual \
indentation<br> >> >> >>> + ret=1<br>
>> >> >>> + which isort<br>
>> >> >>> + echo 'WARNING: tool \
'\''isort'\'' is missing'<br> >> >> \
>>> WARNING: tool 'isort' is missing<br> >> >><br>
>> >> This is just a warning<br>
>> >><br>
>> >> >>> + exit 1<br>
>> >><br>
>> >> Most likely the error causing it to exit 1 happened earlier, \
please<br> >> >> check/share<br>
>> >> more of the output.<br>
>> >><br>
>> >> >>> make[1]: *** [validations] Error 1<br>
>> >> >>> make[1]: Leaving directory<br>
>> >> >>> \
`/home/srosenbe/Documents/git/<wbr>ovirt-engine'<br> >> >> \
>>> make: *** [all-dev] Error 2<br> >> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>--------------------------<br>
>> >> >>><br>
>> >> >>> To attempt to address this issue, we guessed and \
installed<br> >> >> >>> python2-isort<br>
>> >> >>> through yum, though the readme states it is \
optional.<br> >> >> >>><br>
>> >> >>> Though the process continued, it then failed in the \
python module:<br> >> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
/home/srosenbe/Documents/git/<wbr>ovirt-engine/packaging/<wbr>pythonlib/ovirt_engine/<wbr>service.py<br>
>> >> >>><br>
>> >> >>> That error is here:<br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>---<br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> ---<br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
/home/srosenbe/Documents/git/<wbr>ovirt-engine/packaging/<wbr>pythonlib/ovirt_engine/<wbr>service.py:before<br>
>> >> >>> 2018-02-12 12:17:26<br>
>> >> >>> +++<br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
/home/srosenbe/Documents/git/<wbr>ovirt-engine/packaging/<wbr>pythonlib/ovirt_engine/<wbr>service.py:after<br>
>> >> >>> 2018-02-26 12:07:11.233915<br>
>> >> >>> @@ -31,6 +31,7 @@<br>
>> >> >>> import time<br>
>> >> >>><br>
>> >> >>> import daemon<br>
>> >> >>> +<br>
>> >> >>><br>
>> >> >>> from dateutil import tz<br>
>> >> >>><br>
>> >><br>
>> >> This is an output of 'isort --diff', and not the actual \
error.<br> >> >><br>
>> >> (isort --check, which is what we run to test the code, does not \
fail if<br> >> >> the diff it would have suggested consists of only \
difference in the<br> >> >> number<br>
>> >> of empty lines. It would still be nice to patch service.py to \
have<br> >> >> another<br>
>> >> empty line, but not needed).<br>
>> >><br>
>> >> >>> + exit 1<br>
>> >><br>
>> >> Same. Error was most likely earlier.<br>
>> >><br>
>> >> Best regards,<br>
>> >><br>
>> >> >>> make[1]: *** [validations] Error 1<br>
>> >> >>> make[1]: Leaving directory<br>
>> >> >>> \
`/home/srosenbe/Documents/git/<wbr>ovirt-engine'<br> >> >> \
>>> make: *** [all-dev] Error 2<br> >> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>><br>
>> >> >>> \
------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>---<br>
>> >> >>><br>
>> >> >>> Please advise if you have a quick fix or when this \
issue will be<br> >> >> >>> addressed.<br>
>> >> >>><br>
>> >> >>> Thank you for your time and consideration.<br>
>> >> >>><br>
>> >> >>> With Best Regards.<br>
>> >> >>><br>
>> >> >>> Steven Rosenberg.<br>
>> >> >>><br>
>> >> >><br>
>> >> >><br>
>> >> >><br>
>> >> >> --<br>
>> >> >> Martin Perina<br>
>> >> >> Associate Manager, Software Engineering<br>
>> >> >> Red Hat Czech s.r.o.<br>
>> >> ><br>
>> >> ><br>
>> >><br>
>> >><br>
>> >><br>
>> >> --<br>
>> >> Didi<br>
>> ><br>
>> ><br>
>><br>
>><br>
>><br>
>> --<br>
>> Didi<br>
><br>
><br>
><br>
><br>
> --<br>
> Martin Perina<br>
> Associate Manager, Software Engineering<br>
> Red Hat Czech s.r.o.<br>
<br>
<br>
<br>
</div></div><span class="gmail-HOEnZb"><font color="#888888">--<br>
Didi<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div \
dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div \
dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold; \
margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>SANDRO</span> \
<span>BONAZZOLA</span></p><p \
style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px \
4px;text-transform:uppercase"><span>ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG \
VIRTUALIZATION R&D</span></p><p \
style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a \
href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" \
target="_blank">Red Hat <span>EMEA</span></a></p><table border="0" \
style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td \
width="100px"><a href="https://red.ht/sig" target="_blank"><img \
src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" \
width="90" height="auto"></a></td><td style="font-size:10px"><div><a \
href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" \
target="_blank">TRIED. TESTED. \
TRUSTED.</a></div></td></tr></tbody></table><br></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div></div>
_______________________________________________
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic