[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vdsm-devel
Subject:    [vdsm] Re-code /etc/init.d/functions script with Python and move it to vdsm-tool
From:       fsimonce () redhat ! com (Federico Simoncelli)
Date:       2012-05-15 15:22:41
Message-ID: 0f1db5ef-ea02-4ab1-a516-affa22acf4cb () zmail16 ! collab ! prod ! int ! phx2 ! redhat ! com
[Download RAW message or body]

----- Original Message -----
> From: "Lei Li" <lilei at linux.vnet.ibm.com>
> To: "Federico Simoncelli" <fsimonce at redhat.com>, "Dan Kenigsberg" <danken at redhat.com>
> Cc: wenyi at linux.vnet.ibm.com, vdsm-devel at lists.fedorahosted.org
> Sent: Tuesday, May 15, 2012 11:37:39 AM
> Subject: Re: [vdsm] Re-code /etc/init.d/functions script with Python and	move it to vdsm-tool
> 
> On 05/10/2012 03:33 PM, Federico Simoncelli wrote:
> > ----- Original Message -----
> >> From: "Wenyi Gao"<wenyi at linux.vnet.ibm.com>
> >> To:vdsm-devel at lists.fedorahosted.org
> >> Sent: Thursday, May 10, 2012 5:36:08 AM
> >> Subject: [vdsm] Re-code /etc/init.d/functions script with Python
> >> and move it	to vdsm-tool
> >>
> >> Hi All,
> >>
> >> I am working on moving vdsm.init script to vdsm-tool. But the
> >> vdsm.init
> >> script uses some of functions from /etc/init.d/functions. So I
> >> plan
> >> to
> >> re-code the /etc/init.d/functions or part of it with python code
> >> and
> >> also move it to vdsm-tool.  Is it okey?
> > Ah thanks for asking, this is something dear to me :)
> > Basically the init file shouldn't be in python and should look as
> > much as
> > possible like the standard one:
> >
> > http://git.fedorahosted.org/git/?p=rpmdevtools.git;a=blob;f=template.init
> >
> > All the rest should be moved to vdsm-tool as:
> Hi Federico, Dan,
> 
> I am working on moving install/uninstall hooks out of vdsm.spec.in
> file to its own script, the previous patches have been posted to gerrit
> as links below:
> 
> http://gerrit.ovirt.org/#change,4134
> http://gerrit.ovirt.org/#change,4135
> 
> According to Dan's comment, I am working on the code about
> encapsulating each logical function into vdsm-tool function too.
> 
> Saw the discussion, I'd like to ask you what you think of how to
> encapsulate it to vdsm-tool, re-code the scripts in python or just
> put the scripts under the framework of vdsm-tool?

Using python is preferable.

-- 
Federico

[prev in list] [next in list] [prev in thread] [next in thread]