[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vbox-dev
Subject:    Re: [vbox-dev] [PATCH] libalias bug
From:       Klaus Espenlaub <klaus.espenlaub () oracle ! com>
Date:       2013-11-08 17:28:33
Message-ID: 527D1F41.1050001 () oracle ! com
[Download RAW message or body]

Hi Yohanes,

we're not so picky, we take contributions with minor typos in the 
explanation :)

One of our devs looked at the code, and thinks that it needs a little 
more effort to get this fixed properly in all cases (the bug is actually 
coming from the upstream BSD code and is still present there). We should 
have something next week I hope.

Either way, many thanks for bringing this to our attention and preparing 
a patch. Quite easy to reproduce once it's known how to trigger it. 
Somehow it must be possible to trigger it on OSX, too, as we have a hang 
report which looks like a duplicate...

Klaus

On 08.11.2013 05:27, Yohanes Nugroho wrote:
> On Fri, Nov 8, 2013 at 11:16 AM, Yohanes Nugroho <yohanes@gmail.com> wrote:
>> Hi,
>>
>> I have found a bug in libalias, this is a small subtle bug, less than
>> should be greater than in the _attach_handler:
>
> In case it cause confusion between my sentence and the patch, the
> above sentence was wrong and it should read: "greater than should be
> less than".
>
>
>> Index: src/VBox/Devices/Network/slirp/libalias/alias_mod.c
>> ===================================================================
>> --- src/VBox/Devices/Network/slirp/libalias/alias_mod.c (revision 49383)
>> +++ src/VBox/Devices/Network/slirp/libalias/alias_mod.c (working copy)
>> @@ -165,7 +165,7 @@
>>               (b->dir == p->dir) &&
>>               (b->proto == p->proto))
>>               return (EEXIST); /* Priority conflict. */
>> -        if (b->pri > p->pri) {
>> +        if (b->pri < p->pri) {
>>               LIST_INSERT_BEFORE(b, p, entries);
>>               return (0);
>>           }
>

_______________________________________________
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev
[prev in list] [next in list] [prev in thread] [next in thread]