[prev in list] [next in list] [prev in thread] [next in thread] 

List:       vbox-dev
Subject:    Re: [vbox-dev] [PATCH] Correct comment - this file is for FreeBSD.
From:       Alexander Eichner <Alexander.Eichner () oracle ! com>
Date:       2012-09-26 8:19:26
Message-ID: 64A8A041-96AD-47CC-9390-DD8F62D1B3EA () oracle ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi Ed,

thanks for the patch. I committed it, it should appear in the public svn soon.

Regards,
Alexander Eichner

On 25.09.2012 19:04, Ed Maste wrote:

> It appears src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h
> was originally copied from
> src/VBox/Runtime/r0drv/linux/waitqueue-r0drv-linux.h but some comments
> were not updated.
> 
> ---
> src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h \
> b/src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h index b966d1a..a638dd9 \
>                 100644
> --- a/src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h
> +++ b/src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h
> @@ -36,7 +36,7 @@
> #include <iprt/time.h>
> 
> /**
> - * Kernel mode Linux wait state structure.
> + * Kernel mode FreeBSD wait state structure.
> */
> typedef struct RTR0SEMBSDSLEEP
> {
> @@ -259,7 +259,7 @@ DECLINLINE(void) rtR0SemBsdWaitDoIt(PRTR0SEMBSDSLEEP pWait)
> *
> * @returns true / false
> * @param   pWait               The wait structure.
> - * @remarks This shall be called before the first rtR0SemLnxWaitDoIt().
> + * @remarks This shall be called before the first rtR0SemBsdWaitDoIt().
> */
> DECLINLINE(bool) rtR0SemBsdWaitWasInterrupted(PRTR0SEMBSDSLEEP pWait)
> {
> --
> 1.7.11.5
> 
> _______________________________________________
> vbox-dev mailing list
> vbox-dev@virtualbox.org
> https://www.virtualbox.org/mailman/listinfo/vbox-dev

ORACLE Deutschland B.V. & Co. KG   Alexander Eichner
Werkstrasse 24                     Engineer, VirtualBox
71384 Weinstadt, Germany           mailto:alexander.eichner@oracle.com

Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher


[Attachment #5 (unknown)]

<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space; "><div>Hi Ed,</div><div><br></div><div>thanks \
for the patch. I committed it, it should appear in the public svn \
soon.</div><div><br></div><div>Regards,</div><div>Alexander \
Eichner</div><br><div><div>On 25.09.2012 19:04, Ed Maste wrote:</div><br \
class="Apple-interchange-newline"><blockquote type="cite"><div>It appears \
src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h<br>was originally copied \
from<br>src/VBox/Runtime/r0drv/linux/waitqueue-r0drv-linux.h but some \
comments<br>were not updated.<br><br>---<br> \
src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h | 4 ++--<br> 1 file \
changed, 2 insertions(+), 2 deletions(-)<br><br>diff --git \
a/src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h \
b/src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h<br>index b966d1a..a638dd9 \
100644<br>--- a/src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h<br>+++ \
b/src/VBox/Runtime/r0drv/freebsd/sleepqueue-r0drv-freebsd.h<br>@@ -36,7 +36,7 @@<br> \
#include &lt;iprt/time.h&gt;<br><br> /**<br>- * Kernel mode Linux wait state \
structure.<br>+ * Kernel mode FreeBSD wait state structure.<br> &nbsp;*/<br> typedef \
struct RTR0SEMBSDSLEEP<br> {<br>@@ -259,7 +259,7 @@ DECLINLINE(void) \
rtR0SemBsdWaitDoIt(PRTR0SEMBSDSLEEP pWait)<br> &nbsp;*<br> &nbsp;* @returns true / \
false<br> &nbsp;* @param &nbsp;&nbsp;pWait \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;The \
wait structure.<br>- * @remarks This shall be called before the first \
rtR0SemLnxWaitDoIt().<br>+ * @remarks This shall be called before the first \
rtR0SemBsdWaitDoIt().<br> &nbsp;*/<br> DECLINLINE(bool) \
rtR0SemBsdWaitWasInterrupted(PRTR0SEMBSDSLEEP pWait)<br> \
{<br>--<br>1.7.11.5<br><br>_______________________________________________<br>vbox-dev \
mailing list<br><a href="mailto:vbox-dev@virtualbox.org">vbox-dev@virtualbox.org</a><br><a \
href="https://www.virtualbox.org/mailman/listinfo/vbox-dev">https://www.virtualbox.org/mailman/listinfo/vbox-dev</a><br></div></blockquote></div><br><div>
 <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, \
0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: \
-webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; \
word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; \
-webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; \
-webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; \
"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, \
0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; \
text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; \
-webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; \
-webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: \
break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">ORACLE \
Deutschland B.V. &amp; Co. KG &nbsp; Alexander Eichner<br>Werkstrasse 24 &nbsp; \
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Engineer, \
VirtualBox<br>71384 Weinstadt, Germany \
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<a \
href="mailto:frank.mehnert@oracle.com">mailto:alexander.eichner@oracle.com</a><br><br>Hauptverwaltung: \
Riesstr. 25, D-80992 München<br>Registergericht: Amtsgericht München, HRA \
95603</div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space; ">Geschäftsführer: Jürgen \
Kunz<br><br>Komplementärin: ORACLE Deutschland Verwaltung B.V.<br>Rijnzathe 6, 3454PV \
De Meern, Niederlande<br>Handelsregister der Handelskammer Midden-Niederlande, Nr. \
30143697<br>Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val \
Maher</div></span></span> </div>
<br></body></html>



_______________________________________________
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic