[prev in list] [next in list] [prev in thread] [next in thread] 

List:       varnish-commit
Subject:    [7.3] 0b3e67476 h2_vsl_frame: Exit early if masked
From:       Dridi Boukelmoune <dridi.boukelmoune () gmail ! com>
Date:       2023-10-25 14:33:09
Message-ID: 20231025143309.88A4F6E545 () lists ! varnish-cache ! org
[Download RAW message or body]


commit 0b3e67476024d6ef98e65ce4389b21afa9791f2a
Author: Dag Haavi Finstad <daghf@varnish-software.com>
Date:   Mon May 22 10:57:09 2023 +0200

    h2_vsl_frame: Exit early if masked
    
    The VSB bits in here come with a very significant performance penalty
    for H2 request body processing.

diff --git a/bin/varnishd/http2/cache_http2_proto.c b/bin/varnishd/http2/cache_http2_proto.c
index dc3d4a144..fddec7dbf 100644
--- a/bin/varnishd/http2/cache_http2_proto.c
+++ b/bin/varnishd/http2/cache_http2_proto.c
@@ -244,6 +244,10 @@ h2_vsl_frame(const struct h2_sess *h2, const void *ptr, size_t len)
 	const char *p;
 	unsigned u;
 
+	if (VSL_tag_is_masked(SLT_H2RxHdr) &&
+	    VSL_tag_is_masked(SLT_H2RxBody))
+		return;
+
 	AN(ptr);
 	assert(len >= 9);
 	b = ptr;
_______________________________________________
varnish-commit mailing list
varnish-commit@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
[prev in list] [next in list] [prev in thread] [next in thread]