[prev in list] [next in list] [prev in thread] [next in thread] 

List:       varnish-commit
Subject:    [master] 2c2ef29b6 mgt_param: Remove stale comment
From:       Dridi Boukelmoune <dridi.boukelmoune () gmail ! com>
Date:       2023-10-25 7:46:11
Message-ID: 20231025074611.F098211B47C () lists ! varnish-cache ! org
[Download RAW message or body]


commit 2c2ef29b6b2d34e12343aa7f9489d07989cfb9a3
Author: Dridi Boukelmoune <dridi.boukelmoune@gmail.com>
Date:   Wed Oct 25 09:14:23 2023 +0200

    mgt_param: Remove stale comment
    
    We've had contextual min/max/default values in the param.show and
    param.set output and the manual for a while now.

diff --git a/bin/varnishd/mgt/mgt_param.c b/bin/varnishd/mgt/mgt_param.c
index b34fe6772..1cfd789ba 100644
--- a/bin/varnishd/mgt/mgt_param.c
+++ b/bin/varnishd/mgt/mgt_param.c
@@ -857,11 +857,6 @@ MCF_DumpRstParam(void)
 		MCF_DYN_REASON(Minimum, min);
 		MCF_DYN_REASON(Maximum, max);
 #undef MCF_DYN_REASON
-		/*
-		 * XXX: we should mark the params with one/two flags
-		 * XXX: that say if ->min/->max are valid, so we
-		 * XXX: can emit those also in help texts.
-		 */
 		if (pp->flags & ~DOCS_FLAGS) {
 			printf("\t* Flags: ");
 			q = "";
_______________________________________________
varnish-commit mailing list
varnish-commit@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic