[prev in list] [next in list] [prev in thread] [next in thread] 

List:       varnish-commit
Subject:    [7.3] 06f04eceb hpack: Remove redundant/incorrect header validation
From:       Dridi Boukelmoune <dridi.boukelmoune () gmail ! com>
Date:       2023-10-24 15:08:14
Message-ID: 20231024150814.908DA11E1C4 () lists ! varnish-cache ! org
[Download RAW message or body]


commit 06f04eceb1af53db7b38d3d4d19a2300c63ee2be
Author: Walid Boudebouda <walid.boudebouda@gmail.com>
Date:   Fri Sep 8 17:13:19 2023 +0200

    hpack: Remove redundant/incorrect header validation
    
    Control characters will be caught by vct_ishdrval() anyways, but this
    condition would also reject allowed obs-text non-ASCII characters.
    
    Signed-off-by: Dridi Boukelmoune <dridi.boukelmoune@gmail.com>

diff --git a/bin/varnishd/http2/cache_http2_hpack.c b/bin/varnishd/http2/cache_http2_hpack.c
index 74e1d8520..9c179064b 100644
--- a/bin/varnishd/http2/cache_http2_hpack.c
+++ b/bin/varnishd/http2/cache_http2_hpack.c
@@ -75,12 +75,6 @@ h2h_checkhdr(const struct http *hp, const char *b, size_t namelen, size_t len)
 				break;
 			/* FALL_THROUGH */
 		case FLD_NAME:
-			if (*p <= 0x20 || *p >= 0x7f) {
-				VSLb(hp->vsl, SLT_BogoHeader,
-				    "Illegal field header name (control): %.*s",
-				    (int)(len > 20 ? 20 : len), b);
-				return (H2SE_PROTOCOL_ERROR);
-			}
 			if (isupper(*p)) {
 				VSLb(hp->vsl, SLT_BogoHeader,
 				    "Illegal field header name (upper-case): %.*s",
_______________________________________________
varnish-commit mailing list
varnish-commit@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
[prev in list] [next in list] [prev in thread] [next in thread]