[prev in list] [next in list] [prev in thread] [next in thread] 

List:       varnish-commit
Subject:    [master] b1f812182 gc duplicate call to VBP_Update_Backend() when creating backends
From:       Nils Goroll <nils.goroll () uplex ! de>
Date:       2020-12-10 18:43:06
Message-ID: 20201210184306.B933943B0 () lists ! varnish-cache ! org
[Download RAW message or body]


commit b1f812182bb03cb8ffbb5451e1220a729f8afc57
Author: Nils Goroll <nils.goroll@uplex.de>
Date:   Thu Dec 10 19:08:28 2020 +0100

    gc duplicate call to VBP_Update_Backend() when creating backends
    
    VRT_new_backend_clustered() is the only caller of VBP_Insert().
    
    There, VBP_Update_Backend() needs to be called after the director is
    created in order to update the director status for a cold VCL.
    
    For a warm VCL, VBP_Update_Backend() is called via
    VRT_AddDirector() -> VDI_Event() -> vbe_dir_event() -> VBP_Control()
    
    Thus, the additonal call before the director is added to the backend,
    does not do anything but update the poll bits.
    
    Somehow related to #3362

diff --git a/bin/varnishd/cache/cache_backend_probe.c b/bin/varnishd/cache/cache_backend_probe.c
index 8432c8582..8d7a9c9b0 100644
--- a/bin/varnishd/cache/cache_backend_probe.c
+++ b/bin/varnishd/cache/cache_backend_probe.c
@@ -695,7 +695,6 @@ VBP_Insert(struct backend *b, const struct vrt_backend_probe *vp,
 	vbp_build_req(vt, vp, b);
 
 	vbp_reset(vt);
-	VBP_Update_Backend(vt);
 }
 
 void
_______________________________________________
varnish-commit mailing list
varnish-commit@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
[prev in list] [next in list] [prev in thread] [next in thread]