[prev in list] [next in list] [prev in thread] [next in thread] 

List:       varnish-commit
Subject:    [master] b12c73159 silence coverity
From:       Nils Goroll <nils.goroll () uplex ! de>
Date:       2019-03-17 9:32:06
Message-ID: 20190317093206.261EA9B0B8 () lists ! varnish-cache ! org
[Download RAW message or body]


commit b12c73159f8ed75f323f988e7fae9fb05e573361
Author: Nils Goroll <nils.goroll@uplex.de>
Date:   Sun Mar 17 10:25:10 2019 +0100

    silence coverity

diff --git a/bin/varnishd/cache/cache_ban_build.c b/bin/varnishd/cache/cache_ban_build.c
index a3eae6eb2..660bdabc0 100644
--- a/bin/varnishd/cache/cache_ban_build.c
+++ b/bin/varnishd/cache/cache_ban_build.c
@@ -251,7 +251,7 @@ BAN_AddTest(struct ban_proto *bp,
 	}
 
 	op = ban_parse_oper(a2);
-	if (op < 0 ||
+	if (op < _BANS_OPER_OFF ||
 	    ((1U << BAN_OPERIDX(op)) & arg_opervalid[BAN_ARGIDX(pv->tag)]) == 0)
 		return (ban_error(bp,
 		    "expected conditional (%s) got \"%s\"",
_______________________________________________
varnish-commit mailing list
varnish-commit@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
[prev in list] [next in list] [prev in thread] [next in thread]