[prev in list] [next in list] [prev in thread] [next in thread] 

List:       varnish-commit
Subject:    Re: [master] e7d624664 First stab at getting coverity running
From:       Federico Schwindt <fgsch () lodoss ! net>
Date:       2019-03-14 23:23:00
Message-ID: CAJV_h0b9Mg2Qr1wh8uNkYucwOp21t1WnDczwXFsKcZpdz=4Bvg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


I personally like to have everything in plain sight and I really like how
it turned.

Running coverity in a cron was the idea and it's how is implemented after
the second commit.

On Thu, Mar 14, 2019 at 10:34 PM Dridi Boukelmoune <dridi@varni.sh> wrote:

> On Thu, Mar 14, 2019 at 11:13 PM Federico G. Schwindt <fgsch@lodoss.net>
> wrote:
> >
> >
> > commit e7d6246645ba316ac05cc0e5abc9b2e68ba71587
> > Author: Federico G. Schwindt <fgsch@lodoss.net>
> > Date:   Thu Mar 14 22:08:52 2019 +0000
> >
> >     First stab at getting coverity running
>
> Back when I introduced Coverity Scan support in cashpack I managed to
> contain the complexity:
>
> https://github.com/Dridi/cashpack/blob/master/.travis.yml#L50-L57
>
> The ugly part was that 1) I triggered those on demand by pushing
> master to a dedicated "coverity_scan" branch and 2) since I have a
> plethora of jobs in my matrix I wanted to make sure the coverity build
> happened only once:
>
> https://github.com/Dridi/cashpack/blob/master/.travis.yml#L58-L59
>
> And I think it's an opportunity to have a travis/ subdirectory in our
> tools/ directory to offload some of the yaml file complexity to
> external scripts. It worked like a charm for me with vmod-querystring:
>
>
> https://github.com/Dridi/libvmod-querystring/blob/master/.travis.yml#L59-L61
> https://github.com/Dridi/libvmod-querystring/tree/master/travis
>
> If I needed to redo it today, I would use a Travis cron build instead
> of a dedicated branch. The mechanic to detect whether it's a cron
> job or a dedicated branch is basically the same: inspect your
> environment.
>
> I do this to run weekly CI against master instead of my minimum
> required version:
>
>
> https://github.com/Dridi/libvmod-querystring/blob/master/travis/install_varnish.sh
>
> And that's how I'm informed when something lands in master and
> breaks downstream. (VRT, vmodtool, new varnish dependencies...)
>
> HTH
>
>
>
> Dridi
>

[Attachment #5 (text/html)]

<div dir="ltr">I personally like to have everything in plain sight and I really like \
how it turned.<div><br><div>Running coverity in a cron was the idea and it&#39;s how \
is implemented after the second commit.</div></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 14, 2019 at 10:34 \
PM Dridi Boukelmoune &lt;dridi@varni.sh&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">On Thu, Mar 14, 2019 at 11:13 PM Federico G. \
Schwindt &lt;<a href="mailto:fgsch@lodoss.net" \
target="_blank">fgsch@lodoss.net</a>&gt; wrote:<br> &gt;<br>
&gt;<br>
&gt; commit e7d6246645ba316ac05cc0e5abc9b2e68ba71587<br>
&gt; Author: Federico G. Schwindt &lt;<a href="mailto:fgsch@lodoss.net" \
target="_blank">fgsch@lodoss.net</a>&gt;<br> &gt; Date:     Thu Mar 14 22:08:52 2019 \
+0000<br> &gt;<br>
&gt;        First stab at getting coverity running<br>
<br>
Back when I introduced Coverity Scan support in cashpack I managed to<br>
contain the complexity:<br>
<br>
<a href="https://github.com/Dridi/cashpack/blob/master/.travis.yml#L50-L57" \
rel="noreferrer" target="_blank">https://github.com/Dridi/cashpack/blob/master/.travis.yml#L50-L57</a><br>
 <br>
The ugly part was that 1) I triggered those on demand by pushing<br>
master to a dedicated &quot;coverity_scan&quot; branch and 2) since I have a<br>
plethora of jobs in my matrix I wanted to make sure the coverity build<br>
happened only once:<br>
<br>
<a href="https://github.com/Dridi/cashpack/blob/master/.travis.yml#L58-L59" \
rel="noreferrer" target="_blank">https://github.com/Dridi/cashpack/blob/master/.travis.yml#L58-L59</a><br>
 <br>
And I think it&#39;s an opportunity to have a travis/ subdirectory in our<br>
tools/ directory to offload some of the yaml file complexity to<br>
external scripts. It worked like a charm for me with vmod-querystring:<br>
<br>
<a href="https://github.com/Dridi/libvmod-querystring/blob/master/.travis.yml#L59-L61" \
rel="noreferrer" target="_blank">https://github.com/Dridi/libvmod-querystring/blob/master/.travis.yml#L59-L61</a><br>
 <a href="https://github.com/Dridi/libvmod-querystring/tree/master/travis" \
rel="noreferrer" target="_blank">https://github.com/Dridi/libvmod-querystring/tree/master/travis</a><br>
 <br>
If I needed to redo it today, I would use a Travis cron build instead<br>
of a dedicated branch. The mechanic to detect whether it&#39;s a cron<br>
job or a dedicated branch is basically the same: inspect your<br>
environment.<br>
<br>
I do this to run weekly CI against master instead of my minimum<br>
required version:<br>
<br>
<a href="https://github.com/Dridi/libvmod-querystring/blob/master/travis/install_varnish.sh" \
rel="noreferrer" target="_blank">https://github.com/Dridi/libvmod-querystring/blob/master/travis/install_varnish.sh</a><br>
 <br>
And that&#39;s how I&#39;m informed when something lands in master and<br>
breaks downstream. (VRT, vmodtool, new varnish dependencies...)<br>
<br>
HTH<br>
<br>
<br>
<br>
Dridi<br>
</blockquote></div>



_______________________________________________
varnish-commit mailing list
varnish-commit@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic