[prev in list] [next in list] [prev in thread] [next in thread] 

List:       v9fs-developer
Subject:    [V9fs-developer] [bug report] 9p: rdma: RDMA Transport Support for 9P
From:       Dan Carpenter <dan.carpenter () oracle ! com>
Date:       2017-07-14 11:36:53
Message-ID: 20170714113652.jvkh5fpqqa2jxpdy () mwanda
[Download RAW message or body]

[ This one is a decade old so the NULL check probably can be removed.
  -dan ]

Hello Tom Tucker,

This is a semi-automatic email about new static checker warnings.

The patch fc79d4b104f0: "9p: rdma: RDMA Transport Support for 9P"
from Oct 22, 2008, leads to the following Smatch complaint:

    net/9p/trans_rdma.c:303 p9_cm_event_handler()
    error: we previously assumed 'rdma' could be null (see line 277)

net/9p/trans_rdma.c
   276		case RDMA_CM_EVENT_DISCONNECTED:
   277			if (rdma)
                            ^^^^
Check

   278				rdma->state = P9_RDMA_CLOSED;
   279			if (c)
   280				c->status = Disconnected;
   281			break;
   282	
   283		case RDMA_CM_EVENT_TIMEWAIT_EXIT:
   284			break;
   285	
   286		case RDMA_CM_EVENT_ADDR_CHANGE:
   287		case RDMA_CM_EVENT_ROUTE_ERROR:
   288		case RDMA_CM_EVENT_DEVICE_REMOVAL:
   289		case RDMA_CM_EVENT_MULTICAST_JOIN:
   290		case RDMA_CM_EVENT_MULTICAST_ERROR:
   291		case RDMA_CM_EVENT_REJECTED:
   292		case RDMA_CM_EVENT_CONNECT_REQUEST:
   293		case RDMA_CM_EVENT_CONNECT_RESPONSE:
   294		case RDMA_CM_EVENT_CONNECT_ERROR:
   295		case RDMA_CM_EVENT_ADDR_ERROR:
   296		case RDMA_CM_EVENT_UNREACHABLE:
   297			c->status = Disconnected;
   298			rdma_disconnect(rdma->cm_id);
   299			break;
   300		default:
   301			BUG();
   302		}
   303		complete(&rdma->cm_done);
                          ^^^^^^^^^^^^^
Unchecked dereference

   304		return 0;
   305	}

regards,
dan carpenter

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
V9fs-developer mailing list
V9fs-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/v9fs-developer
[prev in list] [next in list] [prev in thread] [next in thread]