[prev in list] [next in list] [prev in thread] [next in thread] 

List:       v9fs-developer
Subject:    Re: [V9fs-developer] TREADDIR: issue when cookie has 64th bit set to 1
From:       DENIEL Philippe <philippe.deniel () cea ! fr>
Date:       2012-07-09 14:45:01
Message-ID: 4FFAEE6D.1060105 () cea ! fr
[Download RAW message or body]

Hi Eric,
>
> I think I'm having a bit of terminology mismatch in my head.  When you
> say cookie, can you map that to the 9p protocol element?  It sounds like
> maybe you are "overloading" the offset to be this cookie?
>   
Sorry for the terminology mismatch. What I call "cookie" is the 
equivalent of the NFS readdir cookie in my server's md cache. I use this 
value as "offset" in 9p.2000L's RREADIR.

>
> Looking through the code, the neo-protocol code which I copied from
> Anthony's original qemu 9p server uses int8_t, int16_t, int32_t, and
> int64_t for all the protocol conversions.  Looking at the Plan 9 code,
> it seems like most things are handled as uchar, ushort, u32int, and
> vlongs (so only 64 bit is signed?).
>   
A "sign mismatch" may explain what I saw.

> A quick search/replace of relevant pieces of client and protocol to
> convert everything to u8, u16, u32, u64 seems to pass my rudimentary
> regressions.  I'm including the patch here for Daniel to test and
> copying Anthony to find out what I probably just broke and jmk to get
> the official Plan 9 read on if there is a good reason why the 64-bit
> quantities are signed in struct Fcall, but all the other bits are
> unsigned.
>
> And of course I'll blame any stupidity on my part on it being early
> Monday morning before coffee.
>   
Once you have a fix to give to me for testing, I am ready to proceed. I 
currently use kernel 3.4.0 from kernel.org.

    Regards

       Philippe

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
V9fs-developer mailing list
V9fs-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/v9fs-developer
[prev in list] [next in list] [prev in thread] [next in thread]