[prev in list] [next in list] [prev in thread] [next in thread]
List: util-linux-ng
Subject: [PATCH 0/6] Test suite fixes for musl libc
From: Patrick Steinhardt <ps () pks ! im>
Date: 2019-08-23 10:16:57
Message-ID: cover.1566555078.git.ps () pks ! im
[Download RAW message or body]
Hi,
on latest master of util-linux, there's currently 20 test- and
subtest failures on musl based systems. There's three different
categories of failures:
- Reliance on buffering properties of stdout/stderr.
- Expectance of non-standard error messages returned by
strerror(3P).
- Expectance of EILSEQ with POSIX locale.
This patch set fixes all of the above, bringing down the number
of failures from 20 to a single test failure. The remaining
failure is in getopt(1), which documents and implicitly relies on
the POSIXLY_CORRECT environment variable when calling getopt_long
from glibc. Adhering to this variable isn't implemented by musl
libc, so to get this working correctly one would have to modify
getopt(1) itself, e.g. by automatically prepending a '+' to the
optstr if the envvar is set. But I'll leave that to another patch
series.
Regards
Patrick
Patrick Steinhardt (6):
tests: remove reliance on buffer behaviour of stderr/stdout streams
tests: colcrt: fix reliance on EILSEQ in POSIX locale
tests: column: use actually invalid multibytes to test encoding
tests: col: avoid hardcoding of errno string
tests: fdisk: avoid hardcoding of errno string
tests: libfdisk: remove reliance on buffer behaviour of standard
streams
tests/commands.sh | 1 +
tests/expected/col/multibyte | 2 +-
tests/expected/column/invalid-multibyte | 2 +-
tests/expected/fdisk/oddinput | 4 +-
tests/expected/libfdisk/mkpart-full-gpt | 14 +++---
.../libfdisk/mkpart-full-gpt-err-overlap | 8 ++--
.../libfdisk/mkpart-full-gpt-nopartno | 14 +++---
.../libfdisk/mkpart-full-gpt-partno-gap | 14 +++---
.../libfdisk/mkpart-full-gpt-space-gap | 10 ++---
.../libfdisk/mkpart-full-mbr-err-logical | 14 +++---
.../libfdisk/mkpart-full-mbr-err-nospace | 6 +--
.../libfdisk/mkpart-full-mbr-err-primary | 6 +--
.../expected/libfdisk/mkpart-full-mbr-logical | 14 +++---
.../libfdisk/mkpart-full-mbr-nopartno | 14 +++---
.../expected/libfdisk/mkpart-full-mbr-primary | 8 ++--
.../libfdisk/mkpart-full-mbr-primary-nopartno | 8 ++--
.../libfdisk/mkpart-full-mbr-space-gap | 6 +--
tests/expected/misc/swaplabel | 2 +-
tests/expected/rename/exit_codes | 2 +-
tests/functions.sh | 7 +++
tests/helpers/Makemodule.am | 3 ++
tests/helpers/test_strerror.c | 44 +++++++++++++++++++
tests/ts/col/multibyte | 5 ++-
tests/ts/colcrt/regressions | 2 +-
tests/ts/column/invalid-multibyte | 2 +-
tests/ts/fdisk/oddinput | 6 ++-
tests/ts/libfdisk/mkpart-full | 26 +++++------
tests/ts/misc/swaplabel | 4 +-
tests/ts/rename/exit_codes | 2 +-
29 files changed, 154 insertions(+), 96 deletions(-)
create mode 100644 tests/helpers/test_strerror.c
--
2.23.0
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic