[prev in list] [next in list] [prev in thread] [next in thread] 

List:       util-linux-ng
Subject:    Re: [PATCH v2 0/7] logger tests do not need /dev/log but socat
From:       Karel Zak <kzak () redhat ! com>
Date:       2015-04-14 10:04:38
Message-ID: 20150414100438.GV3923 () ws ! net ! home
[Download RAW message or body]

On Mon, Apr 13, 2015 at 02:01:46PM +0200, Ruediger Meier wrote:
> Now we require socat for logger tests. We should NOT add fallback to
> netcat-like tools. I have tried this but there are too many different
> and broken netcat versions out there.

I think dependence on socat in the tests is fine, it's unnecessary to
have fallbacks for everything. It's test suite (mostly for developers)
not just some random environment on some random system.

> Ruediger Meier (7):
>   logger: --stderr and --no-act turn "auto-errors" on
>   tests: simplify common logger options
>   tests: logger with socat device
>   tests: logger, validate written socket data
>   tests: logger/errors does not use --no-act
>   tests: add subtests for invalid logger devive
>   travis: install socat

Applied, thanks! It's perfect that we really test sockets now
(--stderr --no-act is poor man solution:-).

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]