[prev in list] [next in list] [prev in thread] [next in thread] 

List:       util-linux-ng
Subject:    Re: [PATCH 08/12] swapon: swaps with legacy version label are not supported
From:       Karel Zak <kzak () redhat ! com>
Date:       2014-04-28 9:00:03
Message-ID: 20140428090003.GM2405 () x2 ! net ! home
[Download RAW message or body]

On Mon, Apr 28, 2014 at 09:44:01AM +0100, Sami Kerola wrote:
> On 28 April 2014 09:37, Benno Schulenberg <bensberg@justemail.net> wrote:
> >
> > On Sun, Apr 27, 2014, at 22:05, Sami Kerola wrote:
> >> -     if (memcmp(buf, "SWAP-SPACE", 10) == 0 ||
> >> -            memcmp(buf, "SWAPSPACE2", 10) == 0)
> >> +     if (memcmp(buf, SWAP_SIGNATURE, 10) == 0)
> >
> > s/10/SWAP_SIGNATURE_SZ/  ?
> 
> Hi Benno,
> 
> Yes, that would be better. Karel, can you amend & add Benno as reviewer?

 Sure, what about to add macro is_swap_magic() to include/ to hide all the
 details? BTW, there is also libblkid/src/superblocks/swap.c :-)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]