[prev in list] [next in list] [prev in thread] [next in thread] 

List:       util-linux-ng
Subject:    Re: [PATCH] fsck/mkfs/mount: unify default search paths for helpers
From:       Mike Frysinger <vapier () gentoo ! org>
Date:       2010-02-03 3:52:13
Message-ID: 201002022252.14183.vapier () gentoo ! org
[Download RAW message or body]

On Tuesday 02 February 2010 08:52:37 Karel Zak wrote:
> On Sun, Jan 24, 2010 at 10:36:55PM -0500, Mike Frysinger wrote:
> > Rather than each fs util having its own search policy, unify the paths in
> > configure and allow them to be tweaked by downstream.  In the process,
> > drop the /etc paths as no one has ever really used these.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> >  configure.ac      |   26 +++++++++
> >  disk-utils/mkfs.c |    2 +-
> >  fsck/fsck.c       |    2 +-
> >  mount/mount.c     |  149
> > +++++++++++++++++++++++++++++------------------------ 4 files changed,
> > 110 insertions(+), 69 deletions(-)
> 
>  Applied, with one important change... (see the patch below)
> 
> > +AS_VAR_SET([fs_paths], [$fs_paths_defaults])
> > +AS_IF([test "x$fs_paths_extra" != "x"],
> > +  [AS_IF([test "x$fs_paths" != "x"], [AS_VAR_APPEND([fs_paths], [:])])
> > +   AS_VAR_APPEND([fs_paths], [$fs_paths_extra])]
> > +)
> 
>  ... the AS_VAR_APPEND() macro is supported since autoconf 2.64. For
>  example the latest stable Fedora still has 2.63. BTW, we still have
>  AC_PREREQ(2.60) in the configure script.
> 
>  I have removed all AS_* macros from your patch, because in whole
>  configure script we use "if", "case", etc.

*shrug* doesnt matter to me.  thanks for merging.
-mike

["signature.asc" (application/pgp-signature)]
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[prev in list] [next in list] [prev in thread] [next in thread]