[prev in list] [next in list] [prev in thread] [next in thread] 

List:       uclinux-dev
Subject:    Re: [uClinux-dev] [PATCH] m68k: restore lost coldfire CLOCK_TICK_RATE
From:       Greg Ungerer <gerg () snapgear ! com>
Date:       2009-06-25 0:33:32
Message-ID: 4A42C5DC.1040103 () snapgear ! com
[Download RAW message or body]

Hi Philippe,

Philippe De Muyter wrote:
> Hi Greg,
> 
> On Mon, Jun 22, 2009 at 01:18:55PM +1000, Greg Ungerer wrote:
> > HI Philippe,
> > 
> > Philippe De Muyter wrote:
> > > Hello list,
> > > The good definition of CLOCK_TICK_RATE for coldfires has been lost in the
> > > merge of m68k and m68knommu include files.  Restore it.  Culprit :
> > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h= \
> > > ebafc17468d58bd903c886175ca84a4edc69ae1d;hp=34055b806a6334624e7e8af6eefc3aee42372a85
> > >                 
> > > Signed-off-by: Philippe De Muyter <phdm@macqel.be>
> > Is it needed?
> > What is broken with the existing value?
> 
> I am no ntp expert, but IIRC kernel/time/ntp.c needs to know the remainder
> of CLOCK_TICK_RATE / HZ to obtain a good stability of the time.  That's
> probably only needed when you have ntpd running.

I thought it did that based on gettimeofday()?  And that ends up
going through the underlying timer code, which for both of
the ColdFire timer types doesn't use CLOCK_TICK_RATE. They directly
use the MCF_CLK definition.

Regards
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev


[prev in list] [next in list] [prev in thread] [next in thread]