[prev in list] [next in list] [prev in thread] [next in thread] 

List:       uclibc
Subject:    Re: [PATCH] include/obstack.h: do not hide _obstack_newchunk
From:       "Anthony G. Basile" <basile () opensource ! dyc ! edu>
Date:       2013-06-29 12:19:58
Message-ID: 51CED0EE.3000809 () opensource ! dyc ! edu
[Download RAW message or body]

On 06/28/2013 09:27 AM, Bernhard Reutner-Fischer wrote:
> On 24 June 2013 17:51, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
>> On 24 June 2013 15:25:20 "Anthony G. Basile" <basile@opensource.dyc.edu>
>> wrote:
>>>
>>> On 06/23/2013 05:25 PM, Anthony G. Basile wrote:
>>>> On 06/23/2013 02:16 PM, Bernhard Reutner-Fischer wrote:
>>>>> On 23 June 2013 18:14:08 "Anthony G. Basile"
>>>>> <basile@opensource.dyc.edu>
>>>>> wrote:
>>>>>> From: "Anthony G. Basile" <blueness@gentoo.org>
>>>>>>
>>>>>> Programs using obstacks, like the suite of utilities provided by
>>>>>> coreutils, need _obstack_newchunk so we unhide the symbol.
>>>>>
>>>>> Eh, that sounds pretty broken. Are you sure this is the right thing to
>>>>> do? They should most likely obstack_*grow() instead.
>>>
>>> Actually its pretty clear what's going on here.  Many obstack functions
>>> are implemented as macros around _obstack_newchunk, so "functions" like
>>> obstack_*grow() are decls which expand to calls to _obstack_newchunk. Read
>>> <obstack.h> around line 292.  Here's a simple poc:
>>
>> Right, completely forgot this.
>> Thanks for the fix!
>
> There was a hidden_def but it was disabled (sloppy grep on my part),
> pushed a fix for this now, thanks!
>

Thanks.  I tested and it works.

-- 
Anthony G. Basile, Ph. D.
Chair of Information Technology
D'Youville College
Buffalo, NY 14201
(716) 829-8197
_______________________________________________
uClibc mailing list
uClibc@uclibc.org
http://lists.busybox.net/mailman/listinfo/uclibc
[prev in list] [next in list] [prev in thread] [next in thread]