[prev in list] [next in list] [prev in thread] [next in thread] 

List:       uclibc
Subject:    [PATCH] Fixing sh4 and sparc builds.
From:       rob () landley ! net (Rob Landley)
Date:       2011-10-29 1:36:14
Message-ID: 4EAB588E.40702 () landley ! net
[Download RAW message or body]

On 10/27/2011 09:38 AM, Austin Foxley wrote:
> On 07/29/2011 08:04 PM, Rob Landley wrote:
>> On 07/29/2011 02:34 PM, Bernhard Reutner-Fischer wrote:
>>>
>>> On Jul 21, 2011 11:05 PM, "Rob Landley"<rob at landley.net
>>> <mailto:rob at landley.net>>  wrote:
>>>>
>>>> I needed the following patch to make sh4 and sparc build with
>>>> pthreads.old in current git:
>>>>
>>>> diff --git a/libc/sysdeps/linux/sh/Makefile.arch
>>> b/libc/sysdeps/linux/sh/Makefile.arch
>>>> index 92e262b..6cbc681 100644
>>>> --- a/libc/sysdeps/linux/sh/Makefile.arch
>>>> +++ b/libc/sysdeps/linux/sh/Makefile.arch
>>>> @@ -9,4 +9,4 @@
>>>>   CSRC := \
>>>>         mmap.c pipe.c __init_brk.c brk.c sbrk.c pread_write.c
>>>> cacheflush.c
>>>>
>>>> -SSRC := setjmp.S __longjmp.S ___fpscr_values.S vfork.S
>>>> +SSRC := setjmp.S __longjmp.S ___fpscr_values.S vfork.S clone.S
>>>> diff --git a/libc/sysdeps/linux/sparc/Makefile.arch
>>> b/libc/sysdeps/linux/sparc/Makefile.arch
>>>> index d0cae9f..820b2fa 100644
>>>> --- a/libc/sysdeps/linux/sparc/Makefile.arch
>>>> +++ b/libc/sysdeps/linux/sparc/Makefile.arch
>>>> @@ -13,7 +13,7 @@ SSRC := \
>>>>
>>>>   ifneq ($(UCLIBC_HAS_THREADS_NATIVE),y)
>>>>   CSRC += sigaction.c
>>>> -SSRC += fork.S vfork.S
>>>> +SSRC += fork.S vfork.S clone.S
>>>>   endif
>>>>
>>>>   # check weather __LONG_DOUBLE_128__ is defined (long double support)
>>>>
>>>> I also had to symlink:
>>>>
>>>>   ln -s ../../../linuxthreads/sysdeps/pthread/tcb-offsets.h
>>> libpthread/linuxthreads.old/sysdeps/pthread/tcb-offsets.h
>>>>
>>>> Because you only have that link in the new pthreads and the sparc
>>> build breaks looking for it on the old one.
>>>
>>> Sounds odd, it should long be used by NPTL, IIRC.
>>
>> If I don't symlink (or in my patch, drop a file there that #includes
>> <../../../blahblahblah>) then it does this:
>>
>> libc/sysdeps/linux/sparc/clone.S:26:25: error: tcb-offsets.h: No such
>> file or directory
>> make: *** [libc/sysdeps/linux/sparc/clone.os] Error 1
>> make: *** Waiting for unfinished jobs....
>>
>> Because sparc's clone.S (which, without the makefile change never got
>> built), does in fact include that file.  which is only there in the new
>> pthread and nptl, but not pthread.old.
>>
>> Here's the config I used, and the patch I used.
>>
>> Rob
> 
> 
> Applied the sparc part of the patch for linuxthreads.old. It looks like
> it was my fault it got broken back in 2009 when I was adding nptl
> support to sparc. Sorry about that.
> 
> -Austin

Yay!

I occasionally poke at NPTL support, but it's not working for me:

  http://lists.busybox.net/pipermail/uclibc/2011-March/045020.html

  http://lists.uclibc.org/pipermail/uclibc/2011-October/045835.html

Need to track down why...

Rob

[prev in list] [next in list] [prev in thread] [next in thread]