[prev in list] [next in list] [prev in thread] [next in thread] 

List:       uclibc
Subject:    [PATCH] Fix minimal locale generation (UCLIBC_BUILD_MINIMAL_LOCALE)
From:       mat () brain-dump ! org (Marc Andre Tanner)
Date:       2009-10-20 8:26:30
Message-ID: 20091020082630.GA2373 () debbook ! brain-dump ! org
[Download RAW message or body]

On Fri, Oct 16, 2009 at 12:03:42PM +0200, Bernhard Reutner-Fischer wrote:
> On Fri, Oct 16, 2009 at 10:03:49AM +0200, Marc Andre Tanner wrote:
> >On Tue, Oct 13, 2009 at 12:01:08PM +0200, Marc Andre Tanner wrote:
> 
> >> Ok, thanks for the clarification. I hope the following patch on top of your 
> >> previous one doese what you want?
> >
> >Could you or someone else please comment on this patch? I would like to get 
> >this functionality included in current git.
> 
> >>  # Warning! Beware tr_TR toupper/tolower exceptions!
> >> -# TODO: handle/prefer UCLIBC_BUILD_MINIMAL_LOCALE ?
> >>  $(locale_OUT)/wctables.h: $(locale_OUT)/gen_wctype
> >>  	@$(disp_gen)
> >> -	$(Q)$< $(FLAG-locale-verbose) en_US > $@ || \
> >> -		$< $(FLAG-locale-verbose) en_US.UTF-8 > $@ || \
> >> -		$< $(FLAG-locale-verbose) en_US.iso8859-1 > $@ || \
> >> -		$< $(FLAG-locale-verbose) en_GB > $@ || \
> >> -		$< $(FLAG-locale-verbose) en_GB.UTF-8 > $@
> >> +	$(Q)for locale in $(call qstrip,$(UCLIBC_BUILD_MINIMAL_LOCALES)) en_US en_GB; do \
> >> +		$< $(FLAG-locale-verbose) $$locale > $@ || \
> >> +		$< $(FLAG-locale-verbose) $$locale.UTF-8 > $@ && break; \
> >> +	done
> 
> previously we had
> for locale in $(call ...);do
>   for charset in '' .UTF-8 .iso8859-1; do
> 
> but you dropped 8859-1 ?

Added it back.

> Please send a complete, tested patch (I've by now deleted what i used to
> describe my initial suggestion).

In case you missed it I have since resent a complete patch with kconfig
integration (don't know if this part is done in the best possible way though).

  http://lists.uclibc.org/pipermail/uclibc/2009-October/043142.html

Please review and commit.

Thanks,
Marc

-- 
 Marc Andre Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[prev in list] [next in list] [prev in thread] [next in thread]