[prev in list] [next in list] [prev in thread] [next in thread] 

List:       uclibc
Subject:    [PATCH] fix unsafe macro calls and questionable casts in libcrypt/md5.c
From:       bernds_cb1 () t-online ! de (Bernd Schmidt)
Date:       2008-06-12 14:00:03
Message-ID: 48512BE3.1030603 () t-online ! de
[Download RAW message or body]

Denys Vlasenko wrote:

> Just noticed this:
[...]
> The attached patch fixes these things. Please review.

So maybe it's ancient grotty code, but presumably it works.  Since we're 
not going to do major development on it or change any of the algorithmic 
parts, it's best left alone, so as to not break the second property by 
accident.  I've seen enough "obvious cleanup" patches subtly break 
critical functionality (see also: openssl debacle) that I think it's 
just not worth it.


Bernd
-- 
This footer brought to you by insane German lawmakers.
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 40368
Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif

[prev in list] [next in list] [prev in thread] [next in thread]