[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ubuntu-devel
Subject:    xorg.conf file validator
From:       bryce () canonical ! com (Bryce Harrington)
Date:       2008-08-26 1:52:47
Message-ID: 20080826015247.GA26279 () bryceharrington ! org
[Download RAW message or body]

Hi Brian,

Thanks again for identifying all of the xorg.conf's from launchpad for
testing X-Kit against.  This has helped make X-Kit more robust.

We realized that this validator might be useful to you too for automated
QA purposes.  Alberto has written a short script using python-xkit that
checks if a given xorg.conf file is valid.

If you have scripts which review incoming bugs, you could use this
script on any that have xorg.conf files attached.

As you can see from Alberto's testing, nearly 1 in 10 xorg.conf's people
submit are broken in some way, so running this validator on them could
help flag them quickly.

Bryce


On Mon, Aug 25, 2008 at 11:09:37AM +0200, Alberto Milone wrote:
> On Fri, 2008-08-22 at 17:21 -0700, Bryce Harrington wrote:
> > On Tue, Aug 12, 2008 at 05:44:24PM +0200, Alberto Milone wrote:
> > > Anyway I have disabled that check and I have added a better one for one word \
> > > options (which are invalid since they have no value assigned e.g. "Option" or \
> > > "Screen" by themselves don't mean anything). 
> > > I have just pushed a new update and I played a bit with Guidance and numbers:
> > > 
> > > Out of ~2010 xorg.conf files:
> > > 
> > > * X-Kit: detected 172 broken xorg.conf files (and I have also checked
> > > the files myself, just to be sure)
> > > 
> > > * Guidance: detected only 7 broken files (included in the ones detected
> > > by X-Kit). 
> > > 
> > > Of course this doesn't mean that X-Kit will detect any broken file but
> > > at least it should be an improvement over Guidance.
> > 
> > Hey, I had a thought.
> > 
> > Could you package up a script that uses xkit to take an xorg.conf file,
> > parse it, catch the exception, print out just the ParseException, and
> > exit with an error code?
> > 
> > Then we could have Brian Murray run it against all OPEN bugs, to
> > auto-comment about the broken xorg.conf file on them.
> > 
> > And perhaps we could hook it up to run on all new xorg.conf attachments
> > that come in.
> > 
> > Oh, and if I didn't mention it earlier, this all looks great.  Let me
> > know if you need more help with getting xkit in.
> > 
> > Bryce
> 
> This is great idea. The only thing I might have to correct in X-Kit is
> this error:
> 
> XKit.xorgparser.ParseException: There cannot be Broken References:
> {'Device': {}, 'InputDevice': {}, 'Screen': {}, 'Monitor': {'Monitor':
> None}, 'ServerLayout': {}}
> 
> I could make it more readable:
> 
> XKit.xorgparser.ParseException: There are Broken References to the
> following sections:
> 'Monitor'
> 
> The former is more useful for debugging though. The other errors should
> be ok.
> 
> Here's a script with a validator class. Currently you can use it in the
> following way:
> python xorgvalidator.py xorg.conf
> 
> Of course the same class can be reused in other programs according to
> Brian Murray's needs.
> 
> http://albertomilone.com/ubuntu/xkit/xorgvalidator.tar.gz
> 
> 
> As regards X-Kit itself, I have just updated EnvyNG (currently only the
> textual installer) and added the support for X-Kit (and some other
> interesting things). Furthermore Mario Limonciello should use it to
> replace Guidance for his mythbuntu since I added the support for X-Kit
> to his program.
> 
> 
> Regards,
> 
> Alberto

----- End forwarded message -----


[prev in list] [next in list] [prev in thread] [next in thread]