[prev in list] [next in list] [prev in thread] [next in thread] 

List:       u-boot
Subject:    Re: [PATCH v5 09/12] efi: smbios: Drop support for SMBIOS2 tables
From:       Heinrich Schuchardt <xypron.glpk () gmx ! de>
Date:       2023-12-31 16:17:28
Message-ID: 71e8c2e3-00c3-40e2-9da6-bdf43ba9cc0d () gmx ! de
[Download RAW message or body]

On 12/31/23 16:25, Simon Glass wrote:
> Only the v3 table is supported now, so always use this when installing
> the EFI table.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
>
> Changes in v5:
> - Add new patch to drop support for SMBIOS2 tables with EFI
>
>   lib/efi_loader/efi_smbios.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/efi_loader/efi_smbios.c b/lib/efi_loader/efi_smbios.c
> index 5cbce6dc4eb..5db342ee0d7 100644
> --- a/lib/efi_loader/efi_smbios.c
> +++ b/lib/efi_loader/efi_smbios.c
> @@ -27,7 +27,6 @@ enum {
>    */
>   efi_status_t efi_smbios_register(void)
>   {
> -	const efi_guid_t *guid;
>   	ulong addr;
>   	efi_status_t ret;
>   	void *buf;
> @@ -47,8 +46,7 @@ efi_status_t efi_smbios_register(void)
>
>   	/* Install SMBIOS information as configuration table */
>   	buf = map_sysmem(addr, 0);
> -	guid = !memcmp(buf, "_SM_", 4) ? &smbios_guid : &smbios3_guid;
> -	ret = efi_install_configuration_table(guid, buf);
> +	ret = efi_install_configuration_table(&smbios3_guid, buf);
>   	unmap_sysmem(buf);
>
>   	return ret;

[prev in list] [next in list] [prev in thread] [next in thread]