[prev in list] [next in list] [prev in thread] [next in thread] 

List:       devicetree
Subject:    Re: [PATCH 1/4] dt-bindings: nvmem: layouts: add U-Boot environment variables layout
From:       Rafał Miłecki <zajec5 () gmail ! com>
Date:       2023-12-18 22:13:52
Message-ID: 5cc586e2-c510-42c0-a451-73a8a129a30f () gmail ! com
[Download RAW message or body]

On 18.12.2023 15:48, Rob Herring wrote:
> 
> On Mon, 18 Dec 2023 14:37:19 +0100, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> > 
> > U-Boot env data is a way of storing firmware variables. It's a format
> > that can be used of top of various storage devices. Its binding should
> > be an NVMEM layout instead of a standalone device.
> > 
> > This patch adds layout binding which allows using it on top of MTD NVMEM
> > device as well as any other. At the same time it deprecates the old
> > combined binding.
> > 
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> > ---
> > .../bindings/nvmem/layouts/u-boot,env.yaml    | 55 +++++++++++++++++++
> > .../devicetree/bindings/nvmem/u-boot,env.yaml |  6 ++
> > 2 files changed, 61 insertions(+)
> > create mode 100644 \
> > Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/u-boot,env.example.dtb: \
> partition@40000: 'ethaddr', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+' \
>                 from schema $id: \
>                 http://devicetree.org/schemas/nvmem/layouts/u-boot,env.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/u-boot,env.example.dtb: \
> partition-u-boot-env: 'ethaddr' does not match any of the regexes: 'pinctrl-[0-9]+' \
> from schema $id: http://devicetree.org/schemas/nvmem/layouts/u-boot,env.yaml#

I checked my binding independently using using dt_binding_check and
missed that. I'm not aware of any way of limiting possibility of
applying binding to specific cases (like "nvmem-layout" node) so I
guess I'll just have to avoid duplicated "u-boot,env" compatible
string.


> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231218133722.16150-1-zajec5@gmail.com
>  
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 


[prev in list] [next in list] [prev in thread] [next in thread]