[prev in list] [next in list] [prev in thread] [next in thread] 

List:       u-boot
Subject:    Re: [[PATCH] colibri_imx6: add board_fit_config_name_match to support FIT in SPL
From:       Sean Anderson <seanga2 () gmail ! com>
Date:       2021-05-31 14:36:37
Message-ID: f6b37ec8-a3c2-db13-8cd1-9f289c387e7f () gmail ! com
[Download RAW message or body]

On 5/31/21 3:06 AM, liu.ming50@gmail.com wrote:
> From: Ming Liu <liu.ming50@gmail.com>
> 
> Only one dtb is currently supported, so match with imx6-colibri.
> 
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
>   board/toradex/colibri_imx6/colibri_imx6.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/board/toradex/colibri_imx6/colibri_imx6.c b/board/toradex/colibri_imx6/colibri_imx6.c
> index c0e7754469..587d92a8e9 100644
> --- a/board/toradex/colibri_imx6/colibri_imx6.c
> +++ b/board/toradex/colibri_imx6/colibri_imx6.c
> @@ -1081,6 +1081,16 @@ void board_init_f(ulong dummy)
>   	board_init_r(NULL, 0);
>   }
>   
> +#ifdef CONFIG_SPL_LOAD_FIT
> +int board_fit_config_name_match(const char *name)
> +{
> +	if (!strcmp(name, "imx6-colibri"))
> +		return 0;
> +
> +	return -1;

Please use an errno.

> +}
> +#endif
> +
>   void reset_cpu(void)
>   {
>   }
> 

Do you need to match "imx6-colibri", or could you use the default config?

--Sean
[prev in list] [next in list] [prev in thread] [next in thread]