[prev in list] [next in list] [prev in thread] [next in thread] 

List:       u-boot
Subject:    Re: [PATCHv2 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning
From:       Neil Armstrong <narmstrong () baylibre ! com>
Date:       2021-05-31 8:42:56
Message-ID: f26aa16e-1fb5-1fe3-9db6-b7dd714f0037 () baylibre ! com
[Download RAW message or body]

On 21/05/2021 18:59, Anand Moon wrote:
> Drop the unused variable warning below.
> 
> drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable
> 			'val' [-Wunused-variable]
>   161 |  u32 val;
>       |      ^~~
> 
> Cc: Patrick Wildt <patrick@blueri.se>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  drivers/pci/pcie_dw_rockchip.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
> index 3ac2434b69..4e448c0a3d 100644
> --- a/drivers/pci/pcie_dw_rockchip.c
> +++ b/drivers/pci/pcie_dw_rockchip.c
> @@ -158,8 +158,6 @@ static inline void rk_pcie_writel_apb(struct rk_pcie *rk_pcie, u32 reg,
>   */
>  static void rk_pcie_configure(struct rk_pcie *pci, u32 cap_speed)
>  {
> -	u32 val;
> -
>  	dw_pcie_dbi_write_enable(&pci->dw, true);
>  
>  	clrsetbits_le32(pci->dw.dbi_base + PCIE_LINK_CAPABILITY,
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
[prev in list] [next in list] [prev in thread] [next in thread]