[prev in list] [next in list] [prev in thread] [next in thread] 

List:       u-boot
Subject:    Re: [PATCH] common: spl: spl_fit.c: report an error on hash check fail
From:       Simon Glass <sjg () chromium ! org>
Date:       2020-11-30 20:12:34
Message-ID: CAPnjgZ2=m9D6p-xjaNdtz2EJwCr72De-13C+1hH5b_5NBWW8Lw () mail ! gmail ! com
[Download RAW message or body]

On Tue, 24 Nov 2020 at 08:15, Philippe Reynes
<philippe.reynes@softathome.com> wrote:
>
> When the hash check fails on a loadable image, the SPL/TPL simply
> jump to the next one. This commit changes this behaviour, when the
> hash check fails on a loadable image, the function spl_load_simple_fit
> stops and report an error.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
> ---
>  common/spl/spl_fit.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

This should have a test. We have sandbox SPL test support now so it
should not be too hard.
[prev in list] [next in list] [prev in thread] [next in thread]