[prev in list] [next in list] [prev in thread] [next in thread] 

List:       u-boot
Subject:    Re: [U-Boot] [PATCH v4 1/2] RiOTboard: add new board
From:       Eric =?UTF-8?B?QsOpbmFyZA==?= <eric () eukrea ! com>
Date:       2014-03-31 20:02:34
Message-ID: 20140331220234.0b2ec49e () e6520eb
[Download RAW message or body]

Hi Stefano,

Le Sun, 30 Mar 2014 18:20:49 +0200,
Stefano Babic <sbabic@denx.de> a écrit :
> A general remark. I agree by reading the whole thread about checking at
> runtime which is the running board (you do it getting the cpu type).
> 
> However, you use also a compiler switch mechanism, adding RIOTBOARD or
> MARSBOARD in the boards.cfg. You have implemented two ways to for the
> same thing. This makes in principle your runtime detection useless,
> because you can use #if CONFIG_MARSBOARD instead of "if board_type ==
> BOARD_IS_MARSBOARD)". Is it possible to use only the runtime detection ?
> I think the main problem is CONFIG_ENV_IS_*, that is different for the
> two boards. What do you think about it ?
> 
I've tried and I don't see how to include functions to handle both MMC
and SF environment in the same binary with the current env code.

A workaround would be to use MMC to store env also on the MarSBoard but
as it is using the SPI flash as the boot source I would prefer to keep
the env in the SPI flash.

Best regards,
Eric
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[prev in list] [next in list] [prev in thread] [next in thread]