[prev in list] [next in list] [prev in thread] [next in thread] 

List:       u-boot
Subject:    Re: [U-Boot] [PATCH v3 13/13] common: fixed linker-list example
From:       Marek Vasut <marex () denx ! de>
Date:       2014-03-31 16:12:22
Message-ID: 201403311812.22225.marex () denx ! de
[Download RAW message or body]

On Monday, March 31, 2014 at 05:49:12 PM, Mateusz Zalega wrote:
> Change-Id: Id1bab29ec026d83f7e811ba82802aad33f77bea0

You samsung guys need to fix your mailers ... and you need to learn to write 
commit messages.

> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@ti.com>

Other than that, please add this for V2:

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  include/linker_lists.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linker_lists.h b/include/linker_lists.h
> index 997d149..557e627 100644
> --- a/include/linker_lists.h
> +++ b/include/linker_lists.h
> @@ -228,7 +228,7 @@
>   * and it's name.
>   *
>   * Example:
> - * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub, cmd.sub) = {
> + * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub) = {
>   *         .x = 3,
>   *         .y = 4,
>   * };

Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[prev in list] [next in list] [prev in thread] [next in thread]