[prev in list] [next in list] [prev in thread] [next in thread] 

List:       twsocket
Subject:    Re: [twsocket] TFtpCli V6 Bug truncated files upon download
From:       "Arno Garrels" <arno.garrels () gmx ! de>
Date:       2006-09-18 12:16:25
Message-ID: 009801c6db1c$4370f000$64b2a8c0 () w2k
[Download RAW message or body]

I was a bit confused by the name MySocketOptions.

So the fix is: 
procedure TCustomWSocket.ASyncReceive()
[..] 
{ DLR Honor the socket options being passed as parameters }
if wsoNoReceiveLoop in MySocketOptions then
    break;
[..]

Arno Garrels wrote:
> The bug is in
> procedure TCustomWSocket.ASyncReceive(
>     Error           : Word;
>     MySocketOptions : TWSocketOptions);
> [..]
>  { DLR Honor the socket options being passed as parameters }
>  if HasOption(FComponentOptions, wsoNoReceiveLoop) then
>      break;
> 
> [..]
> 
> should be:
> { DLR Honor the socket options being passed as parameters }
>  if HasOption(MyComponentOptions, wsoNoReceiveLoop) then
>      break;
> 
> 
> 
> Arno Garrels wrote:
>> Arno Garrels wrote:
>>> Francois Piette wrote:
>>>> Strange.
>>>> Is it totally reproductible ? Or does it occur only ocassinally ?
>>> 
>>> It is totally reproducible! The FD_CLOSE message arrives far before
>>> all data has been read causing ASyncReceive() to break the receive
>>> loop too early.
>> 
>> I wonder why this ComponentOption is needed at all? Shouldn't it
>> be set only when a fast abort is required?
>> 
>> 
>>> 
>>>> 
>>>> Contribute to the SSL Effort. Visit
>>>> http://www.overbyte.be/eng/ssl.html --
>>>> francois.piette@overbyte.be
>>>> Author of ICS (Internet Component Suite, freeware)
>>>> Author of MidWare (Multi-tier framework, freeware)
>>>> http://www.overbyte.be
>>>> 
>>>> ----- Original Message -----
>>>> From: "Arno Garrels" <arno.garrels@gmx.de>
>>>> To: "ICS support mailing" <twsocket@elists.org>
>>>> Sent: Monday, September 18, 2006 12:41 PM
>>>> Subject: [twsocket] TFtpCli V6 Bug truncated files upon download
>>>> 
>>>> 
>>>>> Hi,
>>>>> 
>>>>> TFtpCli V6 truncates downloaded files.
>>>>> I found that wsoNoReceiveLoop causes ASyncReceive()
>>>>> to break even though there is still data pending.
>>>>> 
>>>>> When I set SocketOptions of the datasocket to []
>>>>> downloads work fine.
>>>>> 
>>>>> Any idea why v5 and v6 behave so different?
>>>>> Is this a possible bug in TWsocket?
>>>>> 
>>>>> ---
>>>>> Arno Garrels [TeamICS]
>>>>> http://www.overbyte.be/eng/overbyte/teamics.html
>>>>> 
>>>>> --
>>>>> To unsubscribe or change your settings for TWSocket mailing list
>>>>> please goto http://www.elists.org/mailman/listinfo/twsocket
>>>>> Visit our website at http://www.overbyte.be
-- 
To unsubscribe or change your settings for TWSocket mailing list
please goto http://www.elists.org/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be
[prev in list] [next in list] [prev in thread] [next in thread]