[prev in list] [next in list] [prev in thread] [next in thread] 

List:       turbine-torque-dev
Subject:    [jira] Commented: (TORQUE-120) Inappropriate dependencies on Torque
From:       "Moriyoshi Koizumi (JIRA)" <jira () apache ! org>
Date:       2008-12-10 5:48:46
Message-ID: 396995797.1228888126748.JavaMail.jira () brutus
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/TORQUE-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655104#action_12655104 \
] 

Moriyoshi Koizumi commented on TORQUE-120:
------------------------------------------

From a design perspective, I don't think the instance method should call the static \
method to check if it's been initialized as long as it's possible that each \
TorqueInstance instance has a separate class loader, 

> Inappropriate dependencies on Torque from TorqueInstance
> --------------------------------------------------------
> 
> Key: TORQUE-120
> URL: https://issues.apache.org/jira/browse/TORQUE-120
> Project: Torque
> Issue Type: Bug
> Components: Runtime
> Affects Versions: 3.3
> Environment: Mac OS X Tiger (10.4.11) / PPC
> Reporter: Moriyoshi Koizumi
> 
> I found a number of inappropriate invocations from org.apache.torque.TorqueInstance \
> to static methods of org.apache.torque.Torque. I'm not sure but I suspect this bug \
>                 was created during the transition from Torque to TorqueInstance.
> Index: src/java/org/apache/torque/TorqueInstance.java
> ===================================================================
> --- src/java/org/apache/torque/TorqueInstance.java	(revision 721316)
> +++ src/java/org/apache/torque/TorqueInstance.java	(working copy)
> @@ -312,7 +312,7 @@
> 
> // check that at least the default database has got an adapter.
> Database defaultDatabase
> -                = (Database) databases.get(Torque.getDefaultDB());
> +                = (Database) databases.get(getDefaultDB());
> if (defaultDatabase == null
> > > defaultDatabase.getAdapter() == null)
> {
> @@ -323,7 +323,7 @@
> + "."
> + Torque.DATABASE_KEY
> + "."
> -                    + Torque.getDefaultDB()
> +                    + getDefaultDB()
> + "."
> + DB.ADAPTER_KEY;
> log.error(error);
> @@ -903,7 +903,7 @@
> public Connection getConnection(String name)
> throws TorqueException
> {
> -        if (!Torque.isInit())
> +        if (!isInit())
> {
> throw new TorqueException("Torque is not initialized");
> }
> @@ -966,7 +966,7 @@
> String password)
> throws TorqueException
> {
> -        if (!Torque.isInit())
> +        if (!isInit())
> {
> throw new TorqueException("Torque is not initialized");
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]