[prev in list] [next in list] [prev in thread] [next in thread] 

List:       trousers-tech
Subject:    Re: [TrouSerS-tech] [PATCH 03/17] Inserted missing va_end
From:       "Fuchs, Andreas" <andreas.fuchs () sit ! fraunhofer ! de>
Date:       2014-04-11 9:41:48
Message-ID: 1397209308.15139.23.camel () pc-fuchslap2 ! sit ! fraunhofer ! de
[Download RAW message or body]

Disclaimer:
I could not complie-test or runtime-test these patches right now. This is a pure \
code-only review of the patches.

This seems to be correct.

Am Mittwoch, den 09.04.2014, 15:41 -0300 schrieb rmaciel@linux.vnet.ibm.com:
> From: Richard Maciel <rmaciel@linux.vnet.ibm.com>
> 
> Related to coverit CIDs 10332 and 10333.
> 
> Signed-off-by: Richard Maciel <rmaciel@linux.vnet.ibm.com>
> ---
> src/tcs/tcs_pbg.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/src/tcs/tcs_pbg.c b/src/tcs/tcs_pbg.c
> index e15365c..507cc27 100644
> --- a/src/tcs/tcs_pbg.c
> +++ b/src/tcs/tcs_pbg.c
> @@ -918,6 +918,7 @@ tpm_rsp_parse(TPM_COMMAND_CODE ordinal, BYTE *b, UINT32 len, \
> ...)  default:
> 		LogError("Unknown ordinal: 0x%x", ordinal);
> 		result = TCSERR(TSS_E_INTERNAL_ERROR);
> +		va_end(ap);
> 		break;
> 	}
> 
> @@ -2197,6 +2198,7 @@ tpm_rqu_build(TPM_COMMAND_CODE ordinal, UINT64 *outOffset, \
> BYTE *out_blob, ...)  }
> #endif
> 	default:
> +		va_end(ap);
> 		LogError("Unknown ordinal: 0x%x", ordinal);
> 		break;
> 	}

------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
TrouSerS-tech mailing list
TrouSerS-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/trousers-tech


[prev in list] [next in list] [prev in thread] [next in thread]