[prev in list] [next in list] [prev in thread] [next in thread] 

List:       trac
Subject:    Re: [Trac] Javascript checking of button not to be pressed second time
From:       Ryan Ollos <rjollos () gmail ! com>
Date:       2021-08-28 1:39:21
Message-ID: CA+BGpn9eZJnRu2CGQFZQhxvEZP2rK+iY7ye8D1-WcRUEOZXbYA () mail ! gmail ! com
[Download RAW message or body]

On Fri, Aug 27, 2021 at 6:34 PM Валерий Заподовников \
<val.zapod.vz@gmail.com> wrote:

> Sometimes when you click (fast) twice on create ticket or send a comment,
> it just sends it two times. Happened many times, last time here:
> https://trac.ffmpeg.org/ticket/9390#comment:4
> 
> Please fix, click on the button should disable that button, that is like
> 101 of Javascript!
> 
> If fixed, please point out the commit.
> 
> Thanks.
> 

The issue was fixed in Trac 1.0.2:
https://trac.edgewall.org/wiki/TracChangeLog#a1.0.2
The relevant entry is:
Multiple forms submits are disallowed (#10138).

See https://trac.edgewall.org/ticket/10138.

There is a problem with your installation. The browser console shows:

9390:73 Uncaught TypeError: $(...).disableSubmit is not a function
    at HTMLDocument.<anonymous> (9390:73)
    at o (jquery.js:2)
    at Object.fireWith (jquery.js:2)
    at Function.ready (jquery.js:2)
    at HTMLDocument.B (jquery.js:2)

I suspect the static assets were not redeployed after upgrading Trac:
https://trac.edgewall.org/wiki/TracUpgrade#a6.Refreshstaticresources

More details in this ticket:
https://trac.edgewall.org/ticket/12696

Ryan

-- 
You received this message because you are subscribed to the Google Groups "Trac \
Users" group. To unsubscribe from this group and stop receiving emails from it, send \
an email to trac-users+unsubscribe@googlegroups.com. To view this discussion on the \
web visit https://groups.google.com/d/msgid/trac-users/CA%2BBGpn9eZJnRu2CGQFZQhxvEZP2rK%2BiY7ye8D1-WcRUEOZXbYA%40mail.gmail.com.



[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Fri, Aug 27, 2021 at 6:34 PM Валерий \
Заподовников &lt;<a \
href="mailto:val.zapod.vz@gmail.com">val.zapod.vz@gmail.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Sometimes when you \
click (fast) twice on create ticket or send a comment, it just sends it two times. \
Happened many times, last time here:  <a \
href="https://trac.ffmpeg.org/ticket/9390#comment:4" \
target="_blank">https://trac.ffmpeg.org/ticket/9390#comment:4</a><div><br></div><div>Please \
fix, click on the button should disable that button, that is like 101 of Javascript!  \
</div><div><br></div><div>If fixed, please point out the \
commit.</div><div><br></div><div>Thanks.</div></blockquote><div><br></div><div>The \
issue was fixed in Trac 1.0.2:</div><div><a \
href="https://trac.edgewall.org/wiki/TracChangeLog#a1.0.2">https://trac.edgewall.org/wiki/TracChangeLog#a1.0.2</a><br></div><div>The \
relevant entry is:</div><div>Multiple forms submits are disallowed \
(#10138).<br></div><div><br></div><div>See <a \
href="https://trac.edgewall.org/ticket/10138">https://trac.edgewall.org/ticket/10138</a>.</div><div><br></div><div>There \
is a problem with your installation. The browser console shows:</div><div \
class="gmail_quote"><br></div>9390:73 Uncaught TypeError: $(...).disableSubmit is not \
a function<br>      at HTMLDocument.&lt;anonymous&gt; (9390:73)<br>      at o \
(jquery.js:2)<br>      at Object.fireWith (jquery.js:2)<br>      at Function.ready \
(jquery.js:2)<br><div>      at HTMLDocument.B (jquery.js:2)  \
</div><div><br></div><div>I suspect the static assets were not redeployed after \
upgrading Trac:</div><div><a \
href="https://trac.edgewall.org/wiki/TracUpgrade#a6.Refreshstaticresources">https://tr \
ac.edgewall.org/wiki/TracUpgrade#a6.Refreshstaticresources</a><br></div><div><br></div><div>More \
details in this ticket:</div><div><a \
href="https://trac.edgewall.org/ticket/12696">https://trac.edgewall.org/ticket/12696</a><br></div><div><br></div><div>Ryan</div></div></div>


<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &quot;Trac \
Users&quot; group.<br /> To unsubscribe from this group and stop receiving emails \
from it, send an email to <a \
href="mailto:trac-users+unsubscribe@googlegroups.com">trac-users+unsubscribe@googlegroups.com</a>.<br \
/> To view this discussion on the web visit <a \
href="https://groups.google.com/d/msgid/trac-users/CA%2BBGpn9eZJnRu2CGQFZQhxvEZP2rK%2B \
iY7ye8D1-WcRUEOZXbYA%40mail.gmail.com?utm_medium=email&utm_source=footer">https://grou \
ps.google.com/d/msgid/trac-users/CA%2BBGpn9eZJnRu2CGQFZQhxvEZP2rK%2BiY7ye8D1-WcRUEOZXbYA%40mail.gmail.com</a>.<br \
/>



[prev in list] [next in list] [prev in thread] [next in thread]