[prev in list] [next in list] [prev in thread] [next in thread]
List: trac
Subject: Re: [Trac] Re: Any way to notify comment author when their comment is replied to?
From: RjOllos <rjollos () gmail ! com>
Date: 2019-02-20 21:04:42
Message-ID: 16eaa757-c720-44f2-ac54-e2c73143840c () googlegroups ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Wednesday, April 26, 2017 at 11:09:35 PM UTC-7, Peter Suter wrote:
>
> On 27.04.2017 06:53, Dave Huang wrote:
> > Thanks, ReplyToTicketSubscriber works well! Is there a way to enable it
> > by default (e.g., in the notification-subscriber section of trac.ini)? I
> > tried adding "notify_replies = ReplyToTicketSubscriber" to the
> > notification-subscriber section, but it didn't show up in the Default
> > rules section of the Preferences Notifications tab.
> >
> > I noticed that in the plugin's source, the default_subscriptions
> > function returned [], whereas the INotificationSubscribers that are in
> > the Trac core all do something like "return
> > NotificationSystem(self.env).default_subscriptions(klass)" (e.g.,
> >
> https://trac.edgewall.org/browser/branches/1.2-stable/trac/ticket/notification.py?rev=15714#L307). \
>
> >
> >
> > I tried changing ReplyToTicketSubscriber's default_subscriptions to do
> > the same thing, which made it show up as a Default rule in the
> > Notifications Preferences, but I don't actually get any notifications
> > from it (whereas if I add it under Subscription rules, it works as
> > expected). I haven't tried looking into it further; I wanted to check
> > with the mailing list first to see if y'all had any suggestions :)
> >
>
> You're probably on the right track, but also need one more thing:
> Add back the "default_subscriptions()" handling in "matches()".
> I removed that part[1] because the part you now added was still missing.
> (Please add them both to the wiki page after confirming that it works.)
>
> [1] The first chunk in
>
> https://trac.edgewall.org/wiki/CookBook/Notification/Subscriptions?action=diff&version=11&old_version=10 \
>
>
> Peter
>
Saw that it was edited today
in: https://trac.edgewall.org/wiki/CookBook/Notification/Subscriptions?version=16
- Ryan
--
You received this message because you are subscribed to the Google Groups "Trac \
Users" group. To unsubscribe from this group and stop receiving emails from it, send \
an email to trac-users+unsubscribe@googlegroups.com. To post to this group, send \
email to trac-users@googlegroups.com. Visit this group at \
https://groups.google.com/group/trac-users. For more options, visit \
https://groups.google.com/d/optout.
[Attachment #5 (text/html)]
<div dir="ltr"><br><br>On Wednesday, April 26, 2017 at 11:09:35 PM UTC-7, Peter Suter \
wrote:<blockquote class="gmail_quote" style="margin: 0;margin-left: \
0.8ex;border-left: 1px #ccc solid;padding-left: 1ex;">On 27.04.2017 06:53, Dave Huang \
wrote: <br>> Thanks, ReplyToTicketSubscriber works well! Is there a way to enable \
it <br>> by default (e.g., in the notification-subscriber section of trac.ini)? I \
<br>> tried adding "notify_replies = ReplyToTicketSubscriber" to the
<br>> notification-subscriber section, but it didn't show up in the Default
<br>> rules section of the Preferences Notifications tab.
<br>>
<br>> I noticed that in the plugin's source, the default_subscriptions
<br>> function returned [], whereas the INotificationSubscribers that are in
<br>> the Trac core all do something like "return
<br>> NotificationSystem(self.env).<wbr>default_subscriptions(klass)" (e.g.,
<br>> <a href="https://trac.edgewall.org/browser/branches/1.2-stable/trac/ticket/notification.py?rev=15714#L307" \
target="_blank" rel="nofollow" \
onmousedown="this.href='https://www.google.com/url?q\x3dhttps%3A%2F%2Ftrac.edgewal \
l.org%2Fbrowser%2Fbranches%2F1.2-stable%2Ftrac%2Fticket%2Fnotification.py%3Frev%3D1571 \
4%23L307\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEZYvu8k57KC-V4sgfuN4z6DYuqvQ';return \
true;" onclick="this.href='https://www.google.com/url?q\x3dhttps%3A%2F%2Ftrac.edge \
wall.org%2Fbrowser%2Fbranches%2F1.2-stable%2Ftrac%2Fticket%2Fnotification.py%3Frev%3D1 \
5714%23L307\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEZYvu8k57KC-V4sgfuN4z6DYuqvQ';return \
true;">https://trac.edgewall.org/<wbr>browser/branches/1.2-stable/<wbr>trac/ticket/notification.py?<wbr>rev=15714#L307</a>). \
<br>>
<br>>
<br>> I tried changing ReplyToTicketSubscriber's default_subscriptions to do
<br>> the same thing, which made it show up as a Default rule in the
<br>> Notifications Preferences, but I don't actually get any notifications
<br>> from it (whereas if I add it under Subscription rules, it works as
<br>> expected). I haven't tried looking into it further; I wanted to check
<br>> with the mailing list first to see if y'all had any suggestions :)
<br>>
<br>
<br>You're probably on the right track, but also need one more thing:
<br>Add back the "default_subscriptions()" handling in \
"matches()". <br>I removed that part[1] because the part you now added was \
still missing. <br>(Please add them both to the wiki page after confirming that it \
works.) <br>
<br>[1] The first chunk in
<br><a href="https://trac.edgewall.org/wiki/CookBook/Notification/Subscriptions?action=diff&version=11&old_version=10" \
target="_blank" rel="nofollow" \
onmousedown="this.href='https://www.google.com/url?q\x3dhttps%3A%2F%2Ftrac.edgewal \
l.org%2Fwiki%2FCookBook%2FNotification%2FSubscriptions%3Faction%3Ddiff%26version%3D11% \
26old_version%3D10\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGM0qRgOTw1AuAYv5ijkkdOhmP6_g';return \
true;" onclick="this.href='https://www.google.com/url?q\x3dhttps%3A%2F%2Ftrac.edge \
wall.org%2Fwiki%2FCookBook%2FNotification%2FSubscriptions%3Faction%3Ddiff%26version%3D \
11%26old_version%3D10\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGM0qRgOTw1AuAYv5ijkkdOhmP6_g';return \
true;">https://trac.edgewall.org/<wbr>wiki/CookBook/Notification/<wbr>Subscriptions?action=diff&<wbr>version=11&old_version=10</a>
<br>
<br>
<br>Peter
<br></blockquote><div><br></div><div>Saw that it was edited today in: \
https://trac.edgewall.org/wiki/CookBook/Notification/Subscriptions?version=16</div><div><br></div><div>- \
Ryan </div></div>
<p></p>
-- <br />
You received this message because you are subscribed to the Google Groups "Trac \
Users" group.<br /> To unsubscribe from this group and stop receiving emails \
from it, send an email to <a \
href="mailto:trac-users+unsubscribe@googlegroups.com">trac-users+unsubscribe@googlegroups.com</a>.<br \
/> To post to this group, send email to <a \
href="mailto:trac-users@googlegroups.com">trac-users@googlegroups.com</a>.<br /> \
Visit this group at <a \
href="https://groups.google.com/group/trac-users">https://groups.google.com/group/trac-users</a>.<br \
/> For more options, visit <a \
href="https://groups.google.com/d/optout">https://groups.google.com/d/optout</a>.<br \
/>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic