[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tpmdd-devel
Subject:    Re: [tpmdd-devel] [PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj()
From:       Jason Gunthorpe <jgunthorpe () obsidianresearch ! com>
Date:       2015-11-09 22:32:16
Message-ID: 20151109223216.GA1305 () obsidianresearch ! com
[Download RAW message or body]

On Fri, Nov 06, 2015 at 04:23:56PM -0800, Jeremiah Mahler wrote:
> On Fri, Oct 16, 2015 at 09:40:22PM +0300, Jarkko Sakkinen wrote:
> > Added a new function __compat_only_sysfs_link_group_to_kobj() that adds
> > a symlink from attribute or group to a kobject. This needed for
> > maintaining backwards compatibility with PPI attributes in the TPM
> > driver.

> One problem with this patch is that it adds a bunch of code but none of
> it is used.  So if there is a bug, git bisect will point to a later
> patch instead of this one.

It is fairly standard practice to split cross-subsystem patches like
this, it aids review. git bisect is not a perfect tool.

Jason

------------------------------------------------------------------------------
Presto, an open source distributed SQL query engine for big data, initially
developed by Facebook, enables you to easily query your data on Hadoop in a 
more interactive manner. Teradata is also now providing full enterprise
support for Presto. Download a free open source copy now.
http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
[prev in list] [next in list] [prev in thread] [next in thread]