[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tpmdd-devel
Subject:    Re: [tpmdd-devel] Question about duplicate definitions of transmit_cmd in tpm-sysfs.c and tmp-interf
From:       Nick Krause <xerofoify () gmail ! com>
Date:       2015-01-14 18:21:06
Message-ID: CAPDOMVgw-TojkfOQSwJzS2pAK-TT1d2LEc17dosJv4fHEME4Uw () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jan 14, 2015 at 11:30 AM, Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
> On Fri, 2015-01-02 at 01:48 -0500, nick wrote:
>> Jason,
>> Just a little nitpick but Jarkoo seems to have missed removing the function
>> prototype, tpm_transmit as nothing uses this function anymore.
>
> tpm-dev.c does.
>
>> Regards Nick
>
> /Jarkko
>
>>
>> On 2015-01-02 01:36 AM, Jason Gunthorpe wrote:
>> > On Sat, Dec 27, 2014 at 01:34:51AM -0500, nick wrote:
>> >
>> >> After reading the code and trying various ways to merge these
>> >> functions into tpm.h. I am wondering if the merge is really a good
>> >> idea as it seems to break a lot of code that is very hard to trace
>> >> and redo correctly without a lot of work. Further more I am curious
>> >> as to why the merge is even useful as it seems unneeded to me other
>> >> then to unify the function definitions which seems a minor detail to
>> >> me.
>> >
>> > Jarkko has already sent a patch to merge them, I think you can see the
>> > to be merged patch here:
>> >
>> > https://github.com/PeterHuewe/linux-tpmdd/commit/6e01df24a659c5f21d6beabf9b7a20a85f470cf4
>> >
>> > If you see a problem with it please remark..
>> >
>> > Jason
>> >
>>
>> ------------------------------------------------------------------------------
>> Dive into the World of Parallel Programming! The Go Parallel Website,
>> sponsored by Intel and developed in partnership with Slashdot Media, is your
>> hub for all things parallel software development, from weekly thought
>> leadership blogs to news, videos, case studies, tutorials and more. Take a
>> look and join the conversation now. http://goparallel.sourceforge.net
>> _______________________________________________
>> tpmdd-devel mailing list
>> tpmdd-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
>
>
>
Very well then I missed that. I thought removing that prototype
was fine for that file.
Regards,
Nick

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
[prev in list] [next in list] [prev in thread] [next in thread]