[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tpmdd-devel
Subject:    Re: [tpmdd-devel] [PATCH resend] TPM: Issue TPM_STARTUP at driver load if the TPM has not been start
From:       <Peter.Huewe () infineon ! com>
Date:       2012-11-21 17:37:44
Message-ID: 74A44E99E3274B4CB570415926B37D440F7776 () MUCSE501 ! eu ! infineon ! com
[Download RAW message or body]

Hi Jason,

>Great, I'll send an updated version, thanks!
;) You're welcome.

>> >+struct tpm_startup_in {
>> >+	__be16	startup_type;
>> >+} __packed;
>> 
>> 
>> All the other user
>> __attribute__((packed));
>> Care to change to be consistent?

> I used to __packed to avoid a checkpatch warning, they should probably
> all be changed?

Oh you're right - then sorry about my complaint.
Then I'd prefer submitting it as __packed and write another patch which change the remaining ones.
Are you creating the patch to change or should I?

Peter


------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
[prev in list] [next in list] [prev in thread] [next in thread]