[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tpmdd-devel
Subject:    Re: [tpmdd-devel] [PATCH V3 1/2] driver: add PPI support in tpm driver
From:       Kent Yoder <key () linux ! vnet ! ibm ! com>
Date:       2012-08-15 20:04:58
Message-ID: 20120815200458.GB27618 () linux ! vnet ! ibm ! com
[Download RAW message or body]

On Thu, Jul 12, 2012 at 09:45:29AM -0500, Kent Yoder wrote:
> On Thu, Jul 12, 2012 at 02:38:56AM +0000, Zhang, Xiaoyan wrote:
> > Hi Kent,
> > 
> > Thanks for your comment on the patch. But there's some confusion on my side.
> > You mentioned not to change the tpm driver name. But the driver is linked from \
> > tpm.c and tpm_ppi.c, so I should change the original tpm.c file name, right? Is \
> > it acceptable to change tpm.c to tpm_common.c or tpm_utils.c or else?
> 
> I think you can just add tpm_ppi.c like this:
> 
> diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile
> index beac52f6..96b9222 100644
> --- a/drivers/char/tpm/Makefile
> +++ b/drivers/char/tpm/Makefile
> @@ -4,7 +4,7 @@
> obj-$(CONFIG_TCG_TPM) += tpm.o
> ifdef CONFIG_ACPI
> obj-$(CONFIG_TCG_TPM) += tpm_bios.o
> -       tpm_bios-objs += tpm_eventlog.o tpm_acpi.o
> +       tpm_bios-objs += tpm_eventlog.o tpm_acpi.o tpm_ppi.o
> endif
> obj-$(CONFIG_TCG_TIS) += tpm_tis.o
> obj-$(CONFIG_TCG_TIS_I2C_INFINEON) += tpm_i2c_infineon.o

Hi Xiaoyan,

  Can you please resubmit the PPI patches applying on top of this tree?

  git://github.com:shpedoikal/linux.git v3.6-rc1-tpmdd-staging

Thanks,
Kent

> 
> Kent
> 
> > 
> > Thanks,
> > Xiaoyan
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel


[prev in list] [next in list] [prev in thread] [next in thread]