[prev in list] [next in list] [prev in thread] [next in thread]
List: tortoisesvn-users
Subject: Re: Merge Log text for single revision should look the same as for
From: Jean-Marc van Leerdam <j.m.van.leerdam () gmail ! com>
Date: 2011-11-27 20:29:54
Message-ID: CANLxDyK8yFXFi4_XDAOchiaJPQHpE8q0G11GOpPcNr82dpSijw () mail ! gmail ! com
[Download RAW message or body]
Stefan,
Never mind. See below...
On 27 November 2011 21:11, Jean-Marc van Leerdam
<j.m.van.leerdam@gmail.com>wrote:
> Stefan,
>
> On 23 November 2011 22:54, Stefan Küng <tortoisesvn@gmail.com> wrote:
>
>> On 23.11.2011 22:51, Jean-Marc van Leerdam wrote:
>> > Hi,
>> >
>> > On 8 November 2011 22:21, Jean-Marc van Leerdam
>> > <j.m.van.leerdam@gmail.com <mailto:j.m.van.leerdam@gmail.com>> wrote:
>> >
>> > Hi,
>> >
>> > When merging multiple revisions, the 'show log' dialog conveniently
>> > lists the revision comments of the selected revisions including the
>> > revision numbers. However, when selecting just one revision, the
>> > revision number is omitted. Can this be changed to show the comments
>> > in a consistent way?
>> >
>> > I am used to copying these comments into the commit dialog when
>> > committing the merge, prepending it with a 'Merge revisions from
>> > trunk:' text. For single revision merges I have to remember the
>> > revision number (or open a separate show log).
>> >
>> > Another thing I noticed: the comments from the selected revisions
>> > are shown in reverse order. This does not make sense to me, I expect
>> > the comments to be shown chronologically ascending (old on top). I
>> > know this is different from the list of revisions in the top pane,
>> > but after a copy/paste into the commit dialog it just looks strange.
>> >
>> >
>> > I have not seen any responses to this mail. Does that mean the
>> > suggestions are not useful?
>>
>> It's a good suggestion. But I don't like the idea of adding the rev
>> number to the log message if only one is shown. It makes sense when
>> multiple revs are selected. But not for just one: in that case it would
>> confuse users so they think that the rev is part of the log message.
>>
>> Do you have a suggestion on how to overcome this?
>>
>> Not something that will work for all occasions at the same time.
>
> The only way I see is to add one or two additional strings next to the
> MergeLogSeparator to the Advanced settings page:
> MergeLogOrderAscending (true/false)
> MergeLogTemplateSingle (string pattern)
> MergeLogTemplateMulti (string pattern)
>
> The string patterns use %rev% and %msg% as the placeholders for the
> revision number and original log message.
>
> Anyway, I realize this may be quite some work, and without any supporting
> 'me too' responses probably not worth the effort. Introducing a user
> customizable pattern that drives the replacement code has quite some risk I
> guess.
>
I now see that the 'recent messages' list is populated after a merge is
done. This contains exactly what I need and in the order I expect.
There is a difference in the way the log messages are shown in the merge
dialog (when selecting the revisions to merge) and the 'recent messages'
entry that is created, but I can certainly live with that.
Sorry to have bothered you with this. Keep up the great work!
--
Regards,
Jean-Marc
--
. ___
. @@ // \\ "De Chelonian Mobile"
. (_,\/ \_/ \ TortoiseSVN
. \ \_/_\_/> The coolest Interface to (Sub)Version Control
. /_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2888175
To unsubscribe from this discussion, e-mail: [users-unsubscribe@tortoisesvn.tigris.org].
[Attachment #3 (text/html)]
Stefan,<div><br></div><div>Never mind. See below...<br><br><div \
class="gmail_quote">On 27 November 2011 21:11, Jean-Marc van Leerdam <span \
dir="ltr"><<a href="mailto:j.m.van.leerdam@gmail.com">j.m.van.leerdam@gmail.com</a>></span> \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;">Stefan,<br><br><div class="gmail_quote"><div><div \
class="h5">On 23 November 2011 22:54, Stefan Küng <span dir="ltr"><<a \
href="mailto:tortoisesvn@gmail.com" \
target="_blank">tortoisesvn@gmail.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div>On 23.11.2011 22:51, Jean-Marc van Leerdam wrote:<br>
> Hi,<br>
><br>
> On 8 November 2011 22:21, Jean-Marc van Leerdam<br>
</div><div>> <<a href="mailto:j.m.van.leerdam@gmail.com" \
target="_blank">j.m.van.leerdam@gmail.com</a> <mailto:<a \
href="mailto:j.m.van.leerdam@gmail.com" \
target="_blank">j.m.van.leerdam@gmail.com</a>>> wrote:<br>
><br>
> Hi,<br>
><br>
> When merging multiple revisions, the 'show log' dialog \
conveniently<br> > lists the revision comments of the selected revisions \
including the<br> > revision numbers. However, when selecting just one \
revision, the<br> > revision number is omitted. Can this be changed to show \
the comments<br> > in a consistent way?<br>
><br>
> I am used to copying these comments into the commit dialog when<br>
> committing the merge, prepending it with a 'Merge revisions from<br>
> trunk:' text. For single revision merges I have to remember the<br>
> revision number (or open a separate show log).<br>
><br>
> Another thing I noticed: the comments from the selected revisions<br>
> are shown in reverse order. This does not make sense to me, I expect<br>
> the comments to be shown chronologically ascending (old on top). I<br>
> know this is different from the list of revisions in the top pane,<br>
> but after a copy/paste into the commit dialog it just looks strange.<br>
><br>
><br>
> I have not seen any responses to this mail. Does that mean the<br>
> suggestions are not useful?<br>
<br>
</div>It's a good suggestion. But I don't like the idea of adding the rev<br>
number to the log message if only one is shown. It makes sense when<br>
multiple revs are selected. But not for just one: in that case it would<br>
confuse users so they think that the rev is part of the log message.<br>
<br>
Do you have a suggestion on how to overcome this?<br>
<br></blockquote></div></div><div>Not something that will work for all occasions at \
the same time.</div><div><br></div><div>The only way I see is to add one or two \
additional strings next to the MergeLogSeparator to the Advanced settings page:</div>
<div>MergeLogOrderAscending (true/false)</div><div>MergeLogTemplateSingle (string \
pattern)</div><div>MergeLogTemplateMulti (string \
pattern)</div><div><br></div><div>The string patterns use %rev% and %msg% as the \
placeholders for the revision number and original log message. </div>
<div><br></div><div>Anyway, I realize this may be quite some work, and without any \
supporting 'me too' responses probably not worth the effort. Introducing a \
user customizable pattern that drives the replacement code has quite some risk I \
guess.</div> </div></blockquote><div><br></div><div>I now see that the 'recent \
messages' list is populated after a merge is done. This contains exactly what I \
need and in the order I expect. </div><div><br></div><div>There is a difference in \
the way the log messages are shown in the merge dialog (when selecting the revisions \
to merge) and the 'recent messages' entry that is created, but I can \
certainly live with that.</div> <div><br></div><div>Sorry to have bothered you with \
this. Keep up the great work!</div><div> </div></div>-- \
<br>Regards,<br><br>Jean-Marc<br>--<br>. ___ \
<br>. @@ // \\ "De Chelonian Mobile"<br>
. (_,\/ \_/ \ TortoiseSVN<br>. \ \_/_\_/> The coolest Interface to \
(Sub)Version Control<br>. /_/ \_\ <a \
href="http://tortoisesvn.net">http://tortoisesvn.net</a><br> </div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic