[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tortoisesvn-dev
Subject:    Re: [tortoisesvn] r22809 committed - Do early m_pViewData validity test
From:       Stefan_Küng <tortoisesvn () gmail ! com>
Date:       2012-04-19 16:41:49
Message-ID: 4F90404D.8040704 () gmail ! com
[Download RAW message or body]

On 19.04.2012 08:51, Oto BREZINA wrote:
> BTW What is preffered test for empty(NULL) pointer ?
> pViewData is tested in all ways:
>
> negative tests - leave on no data
>
> pViewData == NULL - my preffered
> pViewData == 0
> !pViewData
>
> positive tests - execute if data
> pViewData

I prefer either
pViewData == NULL

or just
if (pViewData){...}

But you can use whatever you prefer. We don't have rules for this.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2949931

To unsubscribe from this discussion, e-mail: [dev-unsubscribe@tortoisesvn.tigris.org].
[prev in list] [next in list] [prev in thread] [next in thread]