[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tortoisesvn-dev
Subject:    Bug in TortoiseSVN shell extension
From:       Christoph von Wittich <Christoph () ApiViewer ! de>
Date:       2007-10-07 12:37:58
Message-ID: 4708D326.9060902 () ApiViewer ! de
[Download RAW message or body]

Hi!

memory allocated with new[] should be deleted with delete[]
see attached patch

Regards,
Christoph von Wittich
Christoph_vW@ReactOS.org

["preservedir_tortoiseshellext.patch" (text/plain)]

Index: PreserveChdir.cpp
===================================================================
--- PreserveChdir.cpp	(revision 10904)
+++ PreserveChdir.cpp	(working copy)
@@ -48,8 +48,8 @@
 		{
 			SetCurrentDirectory(originalCurrentDirectory);
 		}
-		delete currentDirectory;
-		delete originalCurrentDirectory;
+		delete[] currentDirectory;
+		delete[] originalCurrentDirectory;
 		originalCurrentDirectory = NULL;
 	}
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic