[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tor-dev
Subject:    Re: [tor-dev] channel_t to IP Address
From:       Andrea Shepard <andrea () torproject ! org>
Date:       2014-07-24 12:59:32
Message-ID: 20140724125932.GC2066 () dysnomia ! persephoneslair ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thu, Jul 24, 2014 at 01:55:43PM +0100, Gareth Owen wrote:
> Andrea
> 
> Thanks for taking the time to reply and for the advice.  I have just this
> second discovered this method:
> 
> TO_OR_CIRCUIT(circ)->p_chan->get_remote_descr(TO_OR_CIRCUIT(circ)->p_chan,
> 0)
> 
> which returns the endpoint as a string.  I wonder, is this safer/future
> proof or should this approach be discouraged?

Don't call channel methods directly like that.  Do call something like
channel_get_actual_remote_descr(), channel_get_actual_remote_address(),
or channel_get_canonical_remote_descr() (see code in channel.c for
differences among them) on TO_OR_CIRCUIT(circ)->p_chan.

Note: only do this if you want a string to show the user or something like
that.  If you're going to parse it, it's very much brittle and not future-
proof.


-- 
Andrea Shepard
<andrea@torproject.org>
PGP fingerprint (ECC): BDF5 F867 8A52 4E4A BECF  DE79 A4FF BC34 F01D D536
PGP fingerprint (RSA): 3611 95A4 0740 ED1B 7EA5  DF7E 4191 13D9 D0CF BDA5

[Attachment #5 (application/pgp-signature)]

_______________________________________________
tor-dev mailing list
tor-dev@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev


[prev in list] [next in list] [prev in thread] [next in thread]