[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tor-dev
Subject:    Re: [tor-dev] Version bump of obfsproxy to 0.2.8 in TB breaks FTE
From:       Kevin P Dyer <kpdyer () gmail ! com>
Date:       2014-04-28 18:56:51
Message-ID: CA+PGnj=KeWd+_ga9a95tXbeCv+zLfvxcmKWOVNN2BV4mUZws8A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, Apr 28, 2014 at 11:06 AM, George Kadianakis <desnacked@riseup.net>wrote:

> Kevin P Dyer <kpdyer@gmail.com> writes:
> 
> > Hi Mike,
> > 
> > It looks like [1] broke FTE [2].
> > 
> > Can you hold off on pushing any releases public, until we resolve #11629?
> > 
> > George - Can we revert obfsproxy back to 0.2.4, to give me time to sort
> > this out?
> > 
> 
> Sure, that seems reasonable for now. Could you ensure that the TBB
> team is aware of this downgrade?
> 

Actually, looks like Mike is already on the case! [2]


> BTW, on the long term, I'm not sure if it's a good idea to assume that
> the internal networking API of obfsproxy is stable. It shouldn't
> change frequently, but it wouldn't surprise me if it will need to
> change again at some point.
> 
> Would it make sense to include in FTE the parts of obfsproxy you need?
> Of course, this has other issues, like the fact that we will need to
> fix obfsproxy bugs in FTE too.
> 

I think this will be the best short-term solution, until we find a better
way to refactor the common components into pyptlib or some other shared
library.


> Thanks and sorry for the troubles!
> 

No worries.

-Kevin

[1]
https://github.com/kpdyer/tor-browser-bundle/commit/778e6d65b14f7434c7dc9d0e9bf9b316c4444cc2
 [2]
https://gitweb.torproject.org/builders/tor-browser-bundle.git/commit/793a4cd404516b032bc696b4b0e6bb43bafb2e18



[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 28, 2014 \
at 11:06 AM, George Kadianakis <span dir="ltr">&lt;<a \
href="mailto:desnacked@riseup.net" \
target="_blank">desnacked@riseup.net</a>&gt;</span> wrote:<br>


</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px \
0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>Kevin \
P Dyer &lt;<a href="mailto:kpdyer@gmail.com" target="_blank">kpdyer@gmail.com</a>&gt; \
writes:<br>



<br>
&gt; Hi Mike,<br>
&gt;<br>
&gt; It looks like [1] broke FTE [2].<br>
&gt;<br>
&gt; Can you hold off on pushing any releases public, until we resolve #11629?<br>
&gt;<br>
&gt; George - Can we revert obfsproxy back to 0.2.4, to give me time to sort<br>
&gt; this out?<br>
&gt;<br>
<br>
</div>Sure, that seems reasonable for now. Could you ensure that the TBB<br>
team is aware of this downgrade?<br></blockquote><div><br></div><div>Actually, looks \
like Mike is already on the case! [2]</div><div> </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">




BTW, on the long term, I&#39;m not sure if it&#39;s a good idea to assume that<br>
the internal networking API of obfsproxy is stable. It shouldn&#39;t<br>
change frequently, but it wouldn&#39;t surprise me if it will need to<br>
change again at some point.<br>
<br>
Would it make sense to include in FTE the parts of obfsproxy you need?<br>
Of course, this has other issues, like the fact that we will need to<br>
fix obfsproxy bugs in FTE too.<br></blockquote><div><br></div><div>I think this will \
be the best short-term solution, until we find a better way to refactor the common \
components into pyptlib or some other shared library.</div>


<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
 Thanks and sorry for the troubles!<br>
</blockquote></div><br></div><div class="gmail_extra">No worries.</div><div \
class="gmail_extra"><br></div><div class="gmail_extra">-Kevin</div><div \
class="gmail_extra"><br></div><div class="gmail_extra">[1] <a \
href="https://github.com/kpdyer/tor-browser-bundle/commit/778e6d65b14f7434c7dc9d0e9bf9b316c4444cc2" \
target="_blank">https://github.com/kpdyer/tor-browser-bundle/commit/778e6d65b14f7434c7dc9d0e9bf9b316c4444cc2</a></div>


<div class="gmail_extra">[2] <a \
href="https://gitweb.torproject.org/builders/tor-browser-bundle.git/commit/793a4cd4045 \
16b032bc696b4b0e6bb43bafb2e18">https://gitweb.torproject.org/builders/tor-browser-bundle.git/commit/793a4cd404516b032bc696b4b0e6bb43bafb2e18</a></div>



</div>



_______________________________________________
tor-dev mailing list
tor-dev@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev


[prev in list] [next in list] [prev in thread] [next in thread]