[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tor-cvs
Subject:    [tor-commits] [Git][tpo/applications/tor-browser-build][main] Bug 40740: Android's snowflake ClientT
From:       "Pier Angelo Vendrame \( () pierov\) via tor-commits" <tor-commits () lists ! torproject
Date:       2023-08-28 13:21:55
Message-ID: 64ec9f734723e_42e984b9810685c5 () gitlab-02 ! mail
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / \
tor-browser-build


Commits:
29483c74 by Pier Angelo Vendrame at 2023-08-28T15:20:00+02:00
Bug 40740: Android&#39;s snowflake ClientTransportPlugin parameters.

On Android we set PTs parameters with a patch to
tor-onion-proxy-library, but they were not updated to the same as
desktop.

- - - - -


1 changed file:

- projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch


Changes:

=====================================
projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch
=====================================
@@ -71,7 +71,7 @@ index 2405097..bcb6a37 100644
 -        buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec \
").append(clientPath).append('\n');  +    public TorConfigBuilder \
transportPlugin(String obfsPath, String snowPath) {  +        \
buffer.append("ClientTransportPlugin meek_lite,obfs3,obfs4 exec \
                ").append(obfsPath).append('\n');
-+        buffer.append("ClientTransportPlugin snowflake exec \
").append(snowPath).append(" -url \
https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front \
cdn.sstatic.net -ice \
stun:stun.l.google.com:19302,stun:stun.voip.blackberry.com:3478,stun:stun.altar.com.pl \
:3478,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stu \
n:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.sonetel.net:3478,stun:stun. \
stunprotocol.org:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478\n");
 ++        buffer.append("ClientTransportPlugin snowflake exec \
").append(snowPath).append(" -url \
https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front \
cdn.sstatic.net -ice \
stun:stun.l.google.com:19302,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stu \
n:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478 \
-utls-imitate=hellorandomizedalpn\n");  return this;
      }
  



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/29483c74f79aedce8931b517ddc7bfc134526b2e


-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/29483c74f79aedce8931b517ddc7bfc134526b2e
 You're receiving this email because of your account on gitlab.torproject.org.


[Attachment #5 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" \
"http://www.w3.org/TR/REC-html40/loose.dtd"> <html lang="en" \
style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, \
Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale \
mono, lucida console, monospace;'> <head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>

<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>


<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, "GitLab \
Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto \
Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI \
Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit; }
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; \
font-family: var(--default-regular-font, "GitLab \
Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto \
Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI \
Emoji","Segoe UI Symbol","Noto Color Emoji";'> <div class="content">

<h3 style="margin-top: 20px; margin-bottom: 10px;">
Pier Angelo Vendrame pushed to branch main at <a \
href="https://gitlab.torproject.org/tpo/applications/tor-browser-build">The Tor \
Project / Applications / tor-browser-build</a> </h3>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
Commits:
</h4>
<ul>
<li>
<strong style="font-weight: bold;"><a \
href="https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/29483c74f79aedce8931b517ddc7bfc134526b2e">29483c74</a></strong>
 <div>
<span> by Pier Angelo Vendrame </span> <i> at 2023-08-28T15:20:00+02:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: \
14px; color: #333238; position: relative; font-family: var(--default-mono-font, \
"GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation \
Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida \
console",monospace; word-break: break-all; word-wrap: break-word; background-color: \
#fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid \
#dcdcde;'>Bug 40740: Android's snowflake ClientTransportPlugin parameters.

On Android we set PTs parameters with a patch to
tor-onion-proxy-library, but they were not updated to the same as
desktop.
</pre>
</li>
</ul>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
1 changed file:
</h4>
<ul>
<li class="file-stats">
<a href="#1b0ade7034457aa227a104af3c488a06a98517c1">
projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch
</a>
</li>
</ul>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
Changes:
</h4>
<li id="1b0ade7034457aa227a104af3c488a06a98517c1">
<a href="https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/294 \
83c74f79aedce8931b517ddc7bfc134526b2e#1b0ade7034457aa227a104af3c488a06a98517c1"><strong \
style="font-weight: bold;">projects/tor-onion-proxy-library/0001-Bug-30318-Add-snowflake-support.patch</strong></a>
 <hr style="overflow: hidden; border: 1px solid #e1e1e1;">
<table class="code white" style="border-spacing: 0; border-collapse: collapse; width: \
auto; font-family: monospace; font-size: 90%;" bgcolor="#fff" width="100%" \
cellpadding="0" cellspacing="0"> <tr class="line_holder match" style="line-height: \
1.6;"> <td class="diff-line-num unfold js-unfold old_line" data-linenumber="71" \
style="width: 35px; color: rgba(31,30,36,0.24); border-right-width: 1px; \
border-right-color: #ececef; border-right-style: solid; padding: inherit;" \
align="right" bgcolor="#fbfafd">...</td> <td class="diff-line-num unfold js-unfold \
new_line" data-linenumber="71" style="width: 35px; color: rgba(31,30,36,0.24); \
border-right-width: 1px; border-right-color: #ececef; border-right-style: solid; \
padding: inherit;" align="right" bgcolor="#fbfafd">...</td> <td class="line_content \
match" style="color: rgba(31,30,36,0.24); padding: inherit;" bgcolor="#fbfafd">@@ \
-71,7 +71,7 @@ index 2405097..bcb6a37 100644</td> </tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="71" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 71
</td>
<td class="new_line diff-line-num" data-linenumber="71" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 71
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; \
font-size: 14px; color: #333238; position: relative; font-family: \
var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans \
Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida \
console",monospace; word-break: break-all; word-wrap: break-word; background-color: \
inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;'> \
<span id="LC71" class="line" lang="diff"><span class="gd" style="color: #000; \
background-color: #fdd;">-        buffer.append("ClientTransportPlugin \
meek_lite,obfs3,obfs4 exec ").append(clientPath).append('\n');</span></span> \
</pre></td> </tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="72" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 72
</td>
<td class="new_line diff-line-num" data-linenumber="72" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 72
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; \
font-size: 14px; color: #333238; position: relative; font-family: \
var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans \
Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida \
console",monospace; word-break: break-all; word-wrap: break-word; background-color: \
inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;'> \
<span id="LC72" class="line" lang="diff"><span class="gi" style="color: #000; \
background-color: #dfd;">+    public TorConfigBuilder transportPlugin(String \
obfsPath, String snowPath) {</span></span> </pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="73" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 73
</td>
<td class="new_line diff-line-num" data-linenumber="73" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 73
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; \
font-size: 14px; color: #333238; position: relative; font-family: \
var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans \
Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida \
console",monospace; word-break: break-all; word-wrap: break-word; background-color: \
inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;'> \
<span id="LC73" class="line" lang="diff"><span class="gi" style="color: #000; \
background-color: #dfd;">+        buffer.append("ClientTransportPlugin \
meek_lite,obfs3,obfs4 exec ").append(obfsPath).append('\n');</span></span> \
</pre></td> </tr>
<tr class="line_holder old" style="line-height: 1.6;">
<td class="old_line diff-line-num old" data-linenumber="74" style="width: 35px; \
color: rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #fac5cd; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#f9d7dc"> 74
</td>
<td class="new_line diff-line-num old" data-linenumber="74" style="width: 35px; \
color: rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #fac5cd; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#f9d7dc">  
</td>
<td class="line_content old" style="padding: inherit;" bgcolor="#fbe9eb"><pre \
style='display: block; font-size: 14px; color: #333238; position: relative; \
font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu \
Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale \
mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; \
background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit \
solid #dcdcde;'>-<span id="LC74" class="line" lang="diff"><span class="gi" \
style="color: #000; background-color: #dfd;">+        \
buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url \
https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front \
cdn.sstatic.net -ice stun:stun.l.google.com:19302,stun:stun.<span class="idiff left \
deletion" style="background-color: \
#fac5cd;">voip.blackberry.com:3478,stun:stun.altar.com.pl:3478,stun:stun.</span>antisi \
p.com:3478,stun:stun.bluesip.net:3478,stun:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.<span \
class="idiff right deletion" style="background-color: \
#fac5cd;">sonetel.net:3478,stun:stun.stunprotocol.org:3478,stun:stun.</span>uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478\n");</span></span>
 </pre></td>
</tr>
<tr class="line_holder new" style="line-height: 1.6;">
<td class="old_line diff-line-num new" data-linenumber="75" style="width: 35px; \
color: rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #c7f0d2; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#ddfbe6">  
</td>
<td class="new_line diff-line-num new" data-linenumber="74" style="width: 35px; \
color: rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #c7f0d2; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#ddfbe6"> 74
</td>
<td class="line_content new" style="padding: inherit;" bgcolor="#ecfdf0"><pre \
style='display: block; font-size: 14px; color: #333238; position: relative; \
font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu \
Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale \
mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; \
background-color: inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit \
solid #dcdcde;'>+<span id="LC74" class="line" lang="diff"><span class="gi" \
style="color: #000; background-color: #dfd;">+        \
buffer.append("ClientTransportPlugin snowflake exec ").append(snowPath).append(" -url \
https://snowflake-broker.torproject.net.global.prod.fastly.net/ -front \
cdn.sstatic.net -ice \
stun:stun.l.google.com:19302,stun:stun.antisip.com:3478,stun:stun.bluesip.net:3478,stu \
n:stun.dus.net:3478,stun:stun.epygi.com:3478,stun:stun.sonetel.com:3478,stun:stun.uls.co.za:3478,stun:stun.voipgate.com:3478,stun:stun.voys.nl:3478<span \
class="idiff left right addition" style="background-color: #c7f0d2;"> \
-utls-imitate=hellorandomizedalpn</span>\n");</span></span> </pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="75" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 75
</td>
<td class="new_line diff-line-num" data-linenumber="75" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 75
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; \
font-size: 14px; color: #333238; position: relative; font-family: \
var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans \
Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida \
console",monospace; word-break: break-all; word-wrap: break-word; background-color: \
inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;'> \
<span id="LC75" class="line" lang="diff">         return this;</span> </pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="76" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 76
</td>
<td class="new_line diff-line-num" data-linenumber="76" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 76
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; \
font-size: 14px; color: #333238; position: relative; font-family: \
var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans \
Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida \
console",monospace; word-break: break-all; word-wrap: break-word; background-color: \
inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;'> \
<span id="LC76" class="line" lang="diff">     }</span> </pre></td>
</tr>
<tr class="line_holder" style="line-height: 1.6;">
<td class="old_line diff-line-num" data-linenumber="77" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 77
</td>
<td class="new_line diff-line-num" data-linenumber="77" style="width: 35px; color: \
rgba(31,30,36,0.24); border-right-width: 1px; border-right-color: #ececef; \
border-right-style: solid; padding: inherit;" align="right" bgcolor="#fbfafd"> 77
</td>
<td class="line_content" style="padding: inherit;"><pre style='display: block; \
font-size: 14px; color: #333238; position: relative; font-family: \
var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans \
Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida \
console",monospace; word-break: break-all; word-wrap: break-word; background-color: \
inherit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #dcdcde;'> \
<span id="LC77" class="line" lang="diff"> </span> </pre></td>
</tr>

</table>
<br>
</li>

</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
&#8212;
<br>
<a href="https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/29483c74f79aedce8931b517ddc7bfc134526b2e">View \
it on GitLab</a>. <br>
You're receiving this email because of your account on <a target="_blank" \
rel="noopener noreferrer" \
href="https://gitlab.torproject.org">gitlab.torproject.org</a>. <a \
href="https://gitlab.torproject.org/-/profile/notifications" target="_blank" \
rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> &#183; \
<a href="https://gitlab.torproject.org/help" target="_blank" rel="noopener \
noreferrer" class="help-link">Help</a> <script \
type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View \
Commit","url":"https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/29483c74f79aedce8931b517ddc7bfc134526b2e"}}</script>



</p>
</div>
</body>
</html>



_______________________________________________
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic