[prev in list] [next in list] [prev in thread] [next in thread]
List: tor-cvs
Subject: [tor-commits] [tor/master] Document limitation of log_from_handle
From: nickm () torproject ! org
Date: 2011-08-30 19:58:40
Message-ID: 20110830195840.B28C75E193 () cupani ! torproject ! org
[Download RAW message or body]
commit d1dd9991cd636bafe7543aea4dbb18de69f26202
Author: Steven Murdoch <Steven.Murdoch@cl.cam.ac.uk>
Date: Tue Aug 30 15:02:28 2011 +0100
Document limitation of log_from_handle with partial reads
---
src/common/util.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/common/util.c b/src/common/util.c
index aa344bc..76124ef 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -3654,6 +3654,9 @@ tor_split_lines(smartlist_t *sl, char *buf, int len)
#ifdef MS_WINDOWS
/** Read from stream, and send lines to log at the specified log level.
* Returns -1 if there is a error reading, and 0 otherwise.
+ * If the generated stream is flushed more often than on new lines, or
+ * a read exceeds 256 bytes, lines will be truncated. This should be fixed,
+ * along with the corresponding problem on *nix (see bug #2045).
*/
static int
log_from_handle(HANDLE *pipe, int severity)
_______________________________________________
tor-commits mailing list
tor-commits@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic