[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tomcat-user
Subject:    Re: Response change between 8.5.x and 8.0.x (and earlier versions) W.R.T. Line separator CRLF vs. LF
From:       Christopher Schultz <chris () christopherschultz ! net>
Date:       2017-10-19 17:36:21
Message-ID: 143bbc6e-f0e4-0930-0077-7627af8e7eb1 () christopherschultz ! net
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Adam,

On 10/17/17 12:12 PM, Adam Rauch wrote:
> On 10/16/2017 1:27 PM, Net Dawg wrote:
>> Profuse apologies.  We are unable reproduce this.  However out
>> tests were failing for another reason. 8.5.23 returns 400 error
>> with header "HTTP/1.1 400" where as version 8.0.47 returns the
>> same as "HTTP/1.1 400 Bad Request".  When the tests check for the
>> legacy header they were failing.  As soon as we stopped checking
>> for "Bad Request" our tests work.      On Monday, October 16, 
>> 2017, 8:19:33 AM GMT-10, Mark Thomas <markt@apache.org> wrote: On
>> 16/10/17 18:48, Net Dawg wrote:
>>> We are finding line separator has changed on Mac OS X in
>>> tomcat 8.5.23 response relative to all previous versions of
>>> tomcat we tested (8.0.47, 7.0.72 and 7.0.82).  We see nothing
>>> in change log to understand this change. Specifically, 8.5.23
>>> is generating CRLF in response (showing up as ^M in vim), while
>>> previous versions of tomcat are just producing LF.  As a result
>>> all of our tests based on earlier versions of tomcat are 
>>> failing. Is this a bug, in which case we will wait for fix (and
>>> lets tests fail due to known issue in tomcat) or is this how
>>> tomcat will always generate response going forward - in which
>>> case we will make our tests more lenient to be backward
>>> compatible somehow.
>> Context please. Line separator where exactly?
>> 
>> Mark
>> 
>> 
> 
> As for the removal of response messages in 8.5.x, this appears to
> be an intentional change. From the 8.5.0 section of the change
> log, 
> http://tomcat.apache.org/tomcat-8.5-doc/changelog.html#Tomcat_8.5.0_(m
arkt)
>
>  "RFC 7230 states that clients should ignore reason phrases in
> HTTP/1.1 response messages. Since the reason phrase is optional,
> Tomcat no longer sends it. As a result the system property 
> org.apache.coyote.USE_CUSTOM_STATUS_MSG_IN_HEADER is no longer used
> and has been removed. (markt)"

Yep. Users upgrading between versions probably ought to read the
Migration Guide. Oddly enough, it's listed right there on the page.

http://tomcat.apache.org/migration-85.html#Migrating_from_8.0.x_to_8.5.x

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlno4pQACgkQHPApP6U8
pFh3NxAAs8l4iKFTRQjQrUKo9JKA8N30mdO7RKVGSDFsrLQE0b7PVeHz1SB9d22U
Xp9UY9jRlhXFLLSIQDhoOoNnTGT4SzCMSAJuzlcPWpq2YLNIOIgMHu1AWmvRLUCg
uxuB+WLsQnjbFYkZroY53wddOUc9Dh4JupHXVQlFy5V50/DR9VfTdQ/0/fJLXxR8
yK84ZuFRXPcoWSWOl0Vqd+5A0JjnvPfm4c+DpFEUIlpS+NT0/bbkyJVWFzHNPMXN
KFXT9ccW9kX6kGB18K/9LhvlUhhVZrzO7qejQNwG4WeYUdJkxnDuKqyGx7JANaWM
6UEgx40LfEAKQJXxhZNjCGBWKuToloFfRDeDXt1T/Zw1NmxJ1oLrok1FQhRR8Ztw
JS3WTwnBS0hujw8hrKnHOiVaIhUH12Q8xu1kSVOijwOSowCMwus0kSESDr9yhnDG
p+FQmANqCxs1yqzN7xJdLnTtkqkpO2b/ncRnlqZ/MJtXIE59sGEppfOQWp2OrFaH
qO8BSJIGKFYceaXd/FW5f5vbFQR5A4Jf/qqFK6jTeOp5nw7imzzxx7A72RXVIQfr
/I+575YrIHDXkYLvTAMW2LoV8HzDCw9fWy8BUerSsdntvjVfkpOZqadAkmxyUVgP
vgkXDYSo5dCYmDBzE48ev3a5XE32NCAPuesl7pYQiPdUPV4IsMU=
=YZqS
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]