[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tomcat-dev
Subject:    svn commit: r1803456 - in /tomcat/trunk: java/org/apache/coyote/http2/Http2UpgradeHandler.java
From:       markt () apache ! org
Date:       2017-07-30 19:18:27
Message-ID: 20170730191828.DA7023A26BE () svn01-us-west ! apache ! org
[Download RAW message or body]

Author: markt
Date: Sun Jul 30 19:18:27 2017
New Revision: 1803456

URL: http://svn.apache.org/viewvc?rev=1803456&view=rev
Log:
Mark a scary but low confidence FindBugs issue as a false positive

Modified:
    tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
    tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1803456&r1=1803455&r2=1803456&view=diff
 ==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Sun Jul 30 \
19:18:27 2017 @@ -1534,6 +1534,8 @@ class Http2UpgradeHandler extends Abstra
                     long roundTripTime = System.nanoTime() - \
pingRecord.getSentNanoTime();  roundTripTimes.add(Long.valueOf(roundTripTime));
                     while (roundTripTimes.size() > 3) {
+                        // Ignore the returned value as we just want to reduce
+                        // the queue to 3 entries to use for the rolling average.
                         roundTripTimes.poll();
                     }
                     if (log.isDebugEnabled()) {

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1803456&r1=1803455&r2=1803456&view=diff
 ==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Sun Jul 30 19:18:27 2017
@@ -488,6 +488,12 @@
     <Bug pattern="NN_NAKED_NOTIFY" />
   </Match>
   <Match>
+    <!-- Return value is intentionally ignored. -->
+    <Class name="org.apache.coyote.http2.Http2UpgradeHandler$PingManager" />
+    <Mehtod name="receivePing" />
+    <Bug pattern="RV_RETURN_VALUE_IGNORED" />
+  </Match>
+  <Match>
     <!-- Notify is correct. Condition changed outside of this method. -->
     <Class name="org.apache.coyote.http2.Stream" />
     <Mehtod name="incrementWindowSize" />



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]