[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tigervnc-devel
Subject:    Re: [Tigervnc-devel] [patch] Add support for xorg 1.7.x
From:       Adam Tkac <atkac () redhat ! com>
Date:       2009-12-21 14:14:22
Message-ID: 20091221141422.GA24838 () evileye ! atkac ! englab ! brq ! redhat ! com
[Download RAW message or body]

On Thu, Dec 17, 2009 at 01:54:54PM +0000, Andrew de Quincey wrote:
> Hi, the attached two patches (against tigervnc 1.0.0) are my first
> working version of this.
> 
> I'm building against 1.7.3.901 under gentoo. So far I've only had
> the time to test Xvnc itself, but it seems to be ok so far...
> 

I tuned your latest patches a little and commited them to trunk.
Revision 3928 should work fine with X.Org 1.7 branch. I tested both
Xvnc and libvnc.so.

Unfortunately there is a small problem in the main X.Org which
causes that XOrg log is flooded with errors when libvnc.so is used.
Proposed patch is attached, I'm going to submit it to X.Org upstream.

I think we don't need to commit X.Org support to 1.0 branch, I believe
1.1 will be created soon.

Thanks for your work.

Regards, Adam

-- 
Adam Tkac, Red Hat, Inc.

["0001-Do-not-define-members-of-include-eventstr.h-EventTyp.patch" (text/plain)]

>From 9f48f109872798c70d0215a0c67e4c6462803ee7 Mon Sep 17 00:00:00 2001
From: Adam Tkac <atkac@redhat.com>
Date: Mon, 21 Dec 2009 15:03:30 +0100
Subject: [PATCH] Do not define members of include/eventstr.h:EventType enum conditionally. It can
 break modules which are built in-tree.

---
 include/eventstr.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/include/eventstr.h b/include/eventstr.h
index 0d5b1c6..79685c1 100644
--- a/include/eventstr.h
+++ b/include/eventstr.h
@@ -58,17 +58,13 @@ enum EventType {
     ET_ProximityOut,
     ET_DeviceChanged,
     ET_Hierarchy,
-#if XFreeXDGA
     ET_DGAEvent,
-#endif
     ET_RawKeyPress,
     ET_RawKeyRelease,
     ET_RawButtonPress,
     ET_RawButtonRelease,
     ET_RawMotion,
-#ifdef XQUARTZ
     ET_XQuartz,
-#endif
     ET_Internal = 0xFF /* First byte */
 };
 
-- 
1.6.5.5



------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 

_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel


[prev in list] [next in list] [prev in thread] [next in thread]