[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tcpdump-workers
Subject:    Re: [tcpdump-workers] libpcap pluggable I/O branch, rebased
From:       Ray Bellis via tcpdump-workers <tcpdump-workers () lists ! tcpdump ! org>
Date:       2020-08-21 20:09:50
Message-ID: mailman.119.1598039349.29104.tcpdump-workers () lists ! tcpdump ! org
[Download RAW message or body]

Return-Path: <ray@bellis.me.uk>
Received: from localhost (localhost [127.0.0.1])
	by tuna.sandelman.ca (Postfix) with ESMTP id 6AE8838A1C;
	Fri, 21 Aug 2020 15:49:06 -0400 (EDT)
Received: from tuna.sandelman.ca ([127.0.0.1])
	by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id B4RBdruu30Rc; Fri, 21 Aug 2020 15:48:59 -0400 (EDT)
Received: from mail.portfast.net (mail.portfast.net [IPv6:2a03:9800:20:1::2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by tuna.sandelman.ca (Postfix) with ESMTPS id 6F85B38A1A;
	Fri, 21 Aug 2020 15:48:59 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=portfast.net; s=dkim; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:
	Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
	Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
	List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=eznDqwnfHWS/OKXHdD9swr5r9lzCjDNCtmYsj/KPeKA=; b=VRGmvpWISlQq2+HHff4Em3iaEL
	dr9MOhU8+4SZyKwl+MEFwbE+uylLKYvtX2W7xeh5WXV9Nl9nSoPo5saGYYcp51zsAOtH1e3HNqsP5
	DwP6mfJND9kx58Hu+zcXfYsgyjpK49WKSU8QKlPhEA9hnYaX5mY3CZt8yYpYEvKXQgSA=;
Received: from 88-212-170-130.customer.gigaclear.net ([88.212.170.130]:50263 helo=Rays-MacBook-Pro.local)
	by mail.portfast.net ([188.246.200.9]:465)
	with esmtpsa (fixed_plain:ray@bellis.me.uk) (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
	id 1k9DMF-0004hC-6F (Exim 4.89)
	(return-path <ray@bellis.me.uk>); Fri, 21 Aug 2020 21:09:51 +0100
Subject: Re: libpcap pluggable I/O branch, rebased
To: Michael Richardson <mcr@sandelman.ca>,
 tcpdump-workers <tcpdump-workers@lists.tcpdump.org>
References: <18616.1598038002@localhost>
From: Ray Bellis <ray@bellis.me.uk>
Autocrypt: addr=ray@bellis.me.uk; keydata=
 mQENBFvQpEEBCADBbsjhl44JARZXZoAZXoAxsd/227/ItxFHmo+cogL0qhIvn1F++OozY3mR
 S6ut5iuI1XMGCz2/ewqfp43k2f+o9DxjIBEqKA+M1hg8ivBMWD8//yo8S80DT2Y6GmLnRz64
 sRpw0Z3LcmKULKKDU3lD9Uo05s8c2xUzJTxwxFfpjqA108nEemGnu549qV38Jz1OeuD+7P4R
 3du97DyaaW5gyj/ggtiQxQtkbHG9aFRn0ASGON0uu49vRxaeuKwaGExb6FWYXJJSQLScfJ3i
 356RdwaO/KezCGAhRiJ06AbPTxq2j9cvnShVb1IsxXQn73JgHVsPKDjdYo98ePWYuHWPABEB
 AAG0HVJheSBCZWxsaXMgPHJheUBiZWxsaXMubWUudWs+iQFUBBMBCAA+AhsDBQsJCAcCBhUK
 CQgLAgQWAgMBAh4BAheAFiEEnTo7cotw6xBhK8kRlD9Tw3qX+kIFAl3N5h0FCQPd0P8ACgkQ
 lD9Tw3qX+kJ+MwgAoW1eeAyyDqykaFO+N9XWMcQeFQamm1hWhjNRCOFuygycbwAe0oJPYn+i
 VsDoooJ/5zoHPdRV6boG8jEq8JcFwNHd5AXBPpAY9VA44ro83K7BSLMQRSfXB/OXCf5uSpb7
 6DZQzem3wFys5g4bYqdSzFRiN42SjhSNxyi8KGrcEpqHgrnOBLUh+aPUgcTeFd3Dwxa21Hb/
 qpOZvlKwQ7XjnAA6sMqPOmVJF4bg9D5Jg1jUOexPmwtZ1HN1wbpPZWqy3nGPXaHxHCVBp08M
 7ZAIKf4QTVXcHbNxLwZtFO0TU7SK35xhzx4oy3faQIVh8K+CUMPQGU8TA3o78SefoPI8DrkB
 DQRb0KRXAQgAvveTWC0LkjJ2qTJcYqu0ksRKY44UCHyBNy+SfylH7cGd3FTG5qgPnOAhRAfP
 p7q+rxAep2adQCY4odd0CWQpmg3KhBf1qARW4HqUKMjff8+Gv7YZTiolsH+P8qQamCNemhSa
 8+/vsY0roS25ZWHaHDVSIyyvHU6MsDVX8Z1nc1PwNUEqZST3I5ERVUWY/SQOTJp3fVeaU1Mo
 X3Bmk+7ugmUfb8Ztr63Fv3OrdEVk4ivHD8KP5c49UD9yTsVksfHqV2LN6/zdTU0CvW4SIEtX
 f7xQNG/o2/J50yW4e7g59ElYQZJxCjJwKusIV61aAmCe3OLLN05Kp23RrX4AwY26ewARAQAB
 iQE8BBgBCAAmAhsMFiEEnTo7cotw6xBhK8kRlD9Tw3qX+kIFAl3N5h0FCQPd0OkACgkQlD9T
 w3qX+kKHIggAncjGFT/LRZncAnX1IBwJfqzOzYWLOG4QHPMoHkaxrb+q3GAHXd6RAWgc8UIR
 fLJDowI1f2oMXh/PvqZkiVdy0qNPwhNP+i7r8OE8Co3Q1VA9Cw3Ysj2UGF5TQ2cF36XjuH9H
 uMp8Qy0k3lmHZgf7E/hu8u+O3AoBFG5FQ61fJjKTBazRqZmyxcbVyHHAVoAbOYJU+Mb3vfmy
 UlDa0FHxLHI6+pYEe7IQxzv22lGzdSgr7oVJnAz2V9sodeB2ALs+Jjh2kR0+SVPg+ED+zXWe
 p5alounzwhu2brS/vAJwXQXSb1R/65L4HliZk4poaC7UxC+6j0Fu7ICZa2IR9JpNnA==
Message-ID: <89f780dc-2901-1506-38ef-bf9067b39e77@bellis.me.uk>
Date: Fri, 21 Aug 2020 21:09:50 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <18616.1598038002@localhost>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit



On 21/08/2020 20:26, Michael Richardson wrote:
> 
> Ray, I rebased raybellis-gzip-v2 upon libpcap head.
> Do you have a github that I can add as as reviewer?

Do you mean my github a/c name?   That's just "raybellis".

> Mostly I did this because the FreeBSD tests seemed to fail, and I wanted to
> see them work.  I know this has taken forever.
> 
> There are some changes to use charset_fopen() that I think that I managed to
> port across.  Do you have some tests that you could put this through?

Not any more, but I could likely devise some.

> https://github.com/mcr/libpcap/tree/raybellis-gzip-v2
> 
> https://github.com/the-tcpdump-group/libpcap/pull/914/files
> 
> Thank you.
> I hope to merge it next week, but I want to add:
>   ./configure --enable-ioplugin
> 
> and the equivalent for CMake, but I really am CMake-challenged, so I don't
> really understand how to do the equivalent there.

I am also CMake-challenged.   I loathe it as a build system :p

> I've left a comment in the pull request above where we'd #ifdef out.
> 
> I also wonder if we should have a pcap_enableioplugin() option so that
> applications have to opt-in.  I'm just really concerned about opening up
> holes for some setuid() libpcap system.

I share that concern, but don't know how to address it.

Ray


[Attachment #3 (text/plain)]

_______________________________________________
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers


[prev in list] [next in list] [prev in thread] [next in thread]