[prev in list] [next in list] [prev in thread] [next in thread] 

List:       target-devel
Subject:    Re: [PATCH 1/4] target: core: fix preempt and abort for allreg res
From:       Dmitry Bogdanov <d.bogdanov () yadro ! com>
Date:       2022-09-08 8:34:48
Message-ID: 20220908083448.GA9218 () yadro ! com
[Download RAW message or body]

On Wed, Sep 07, 2022 at 09:18:57AM -0700, Bart Van Assche wrote:
> 
> On 9/7/22 06:58, Dmitry Bogdanov wrote:
> > -             if (pr_reg->pr_res_key != sa_res_key)
> > +             if ((sa_res_key) && (pr_reg->pr_res_key != sa_res_key))
> >                       continue;
> 
> Please do not introduce superfluous parentheses. Four parentheses can be
> left out from the above code without affecting readability.
Ok, will remove.

BR,
 Dmitry
[prev in list] [next in list] [prev in thread] [next in thread]